refactor(wrapper): refactor the cuda setting #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #176 +/- ##
==========================================
- Coverage 86.44% 86.32% -0.12%
==========================================
Files 80 80
Lines 3762 3760 -2
==========================================
- Hits 3252 3246 -6
- Misses 510 514 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Gaiejj
requested review from
rockmagma02 and
zmsn-2077
and removed request for
rockmagma02
rockmagma02
reviewed
Mar 25, 2023
|
|
||
| for _ in range(roll_out_step): | ||
| act = act_fn() | ||
| next_obs, reward, cost, terminated, truncated, info = self.step(act) |
There was a problem hiding this comment.
in all loop of roll_out_step, use same act? it seem like a bug, we must consider the situation roll_out_step != 1
rockmagma02
suggested changes
Mar 25, 2023
| @@ -92,7 +92,7 @@ def __init__(self, env_id: str, num_envs: int = 1, **kwargs) -> None: | |||
| def step( | |||
| self, action: torch.Tensor | |||
| ) -> Tuple[torch.Tensor, torch.Tensor, torch.Tensor, torch.Tensor, torch.Tensor, Dict]: | |||
| obs, reward, cost, terminated, truncated, info = self._env.step(action) | |||
| obs, reward, cost, terminated, truncated, info = self._env.step(action.cpu().numpy()) | |||
There was a problem hiding this comment.
use action.detach().cpu().numpy()
omnisafe/envs/core.py
Outdated
| @@ -217,16 +218,25 @@ def __getattr__(self, name: str) -> Any: | |||
| def step( | |||
| self, action: torch.Tensor | |||
| ) -> Tuple[torch.Tensor, torch.Tensor, torch.Tensor, torch.Tensor, torch.Tensor, Dict]: | |||
| return self._env.step(action) | |||
| obs, reward, cost, terminated, truncated, info = self._env.step(action) | |||
| return ( | |||
There was a problem hiding this comment.
change device only in safety_gymnasium_env.py please, changing device in Wrapper could cause multi-calculating in reset and step
zmsn-2077
added
bug
rockmagma02
suggested changes
Mar 26, 2023
| @@ -75,7 +75,9 @@ class SafetyGymnasiumEnv(CMDP): | |||
| need_auto_reset_wrapper = False | |||
| need_time_limit_wrapper = False | |||
|
|
|||
| def __init__(self, env_id: str, num_envs: int = 1, **kwargs) -> None: | |||
| def __init__( | |||
| self, env_id: str, num_envs: int = 1, device: torch.device = 'cpu', **kwargs | |||
There was a problem hiding this comment.
device: torch.device = torch.device('cpu')
rockmagma02
approved these changes
Mar 26, 2023
zmsn-2077
pushed a commit
that referenced
this pull request
Mar 26, 2023
* refactor(wrapper): refactor the cuda setting * chore: revert train_policy.py * chore: set device in safety_gymnasium_env.py * fix: [pre-commit.ci] auto fixes [...] * fix(safety_gymnasium_env.py): fix device interface --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactor the cuda setting
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format. (required)make lint. (required)make testpass. (required)