Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Evaluator): support auto render as .mp4 videos, add examples and tests #60

Merged
merged 17 commits into from
Dec 27, 2022
Merged

feat(Evaluator): support auto render as .mp4 videos, add examples and tests #60

merged 17 commits into from
Dec 27, 2022

Conversation

muchvo
Copy link
Collaborator

@muchvo muchvo commented Dec 25, 2022

Description

1.Support directly render on server and save episodes as .mp4 videos.
2.Add new tests.
3.Add examples to show how to use.
4.Update some wrappers.
5.After carefully testing.
image

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

zmsn-2077 and others added 13 commits December 22, 2022 14:21
@zmsn-2077 @XuehaiPan
refactor: change the file layout of omnisafe (PKU-Alignment#35)
efaf88c
@muchvo @XuehaiPan
refactor(safety-gymnasium): More OOP style code were used and made be…
636d482 
…tter code and file structure. (PKU-Alignment#37)
@Gaiejj @XuehaiPan
refactor(CPO, PolicyGradient, PCPO, FOCOPS): change the details and y…
91a098c 
…aml files of on policy algorithm. (PKU-Alignment#41)

Co-authored-by: Xuehai Pan <[email protected]>
@Gaiejj @XuehaiPan
feat: add CUP algorithm (PKU-Alignment#43)
8fd1d82 
Co-authored-by: Xuehai Pan <[email protected]>
@zmsn-2077 @XuehaiPan
feat(wrapper): separated wrapper for different algorithmic environmen…
a53b3ca 
…ts (PKU-Alignment#44)
@zmsn-2077 @XuehaiPan
refactor(README): show the implemented algorithms in more detail (PKU…
791f19b 
…-Alignment#47)
@muchvo @XuehaiPan
chore: rename files and enable pylint. (PKU-Alignment#39)
1ed496b 
Co-authored-by: Borong Zhang <[email protected]>
@zmsn-2077 @XuehaiPan
refactor: open pylint in pre-commit (PKU-Alignment#48)
12fbca9 
Co-authored-by: Xuehai Pan <[email protected]>
@muchvo @XuehaiPan
feat(circle, run): support new tasks. (PKU-Alignment#50)
b7baf82 
Co-authored-by: Borong Zhang <[email protected]>
@Gaiejj @XuehaiPan @rockmagma02
feat: add new algorithms (PKU-Alignment#52)
b2e9847 
Co-authored-by: Xuehai Pan <[email protected]>
Co-authored-by: ruiyang sun <[email protected]>
feat: support auto render as .mp4 videos and add examples
fd48944
merge
d73ff52
update some wrappers
e30fded
@muchvo muchvo changed the title feat: support auto render as .mp4 videos, add examples and tests. feat: support auto render as .mp4 videos, add examples and tests Dec 25, 2022
@muchvo muchvo changed the title feat: support auto render as .mp4 videos, add examples and tests feat(Evaluator): support auto render as .mp4 videos, add examples and tests Dec 25, 2022
zmsn-2077
zmsn-2077 reviewed Dec 25, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
zmsn-2077
zmsn-2077 requested changes Dec 25, 2022
View reviewed changes
Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

zmsn-2077
zmsn-2077 approved these changes Dec 25, 2022
View reviewed changes
Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After careful review, I agree with these changes.

calico-1226
calico-1226 approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@calico-1226 calico-1226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve these changes.

@zmsn-2077 zmsn-2077 merged commit 1287695 into PKU-Alignment:main Dec 27, 2022
Gaiejj pushed a commit to Gaiejj/omnisafe_zjy that referenced this pull request Jan 2, 2023
@muchvo @XuehaiPan
@rockmagma02 @zmsn-2077 @Gaiejj
feat(Evaluator): support auto render as .mp4 videos, add examples and…
f6527f0 
… tests (PKU-Alignment#60)

Co-authored-by: Xuehai Pan <[email protected]>
Co-authored-by: Borong Zhang <[email protected]>
Co-authored-by: ruiyang sun <[email protected]>
Co-authored-by: zmsn-2077 <[email protected]>
zmsn-2077 added a commit that referenced this pull request Jan 10, 2023
@muchvo @XuehaiPan
@rockmagma02 @zmsn-2077
feat(Evaluator): support auto render as .mp4 videos, add examples and…
da63edb 
… tests (#60)

Co-authored-by: Xuehai Pan <[email protected]>
Co-authored-by: Borong Zhang <[email protected]>
Co-authored-by: ruiyang sun <[email protected]>
Co-authored-by: zmsn-2077 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmsn-2077 zmsn-2077 zmsn-2077 approved these changes

@calico-1226 calico-1226 calico-1226 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muchvo @zmsn-2077 @calico-1226 @Gaiejj