Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PDS-35] 아카이빙 자료 업로드 API 기능구현 #3

Merged
merged 9 commits into from
Oct 14, 2023

Conversation

dangnak2
Copy link
Contributor

@dangnak2 dangnak2 commented Oct 14, 2023

✈️ 지라 티켓

  • PDS-35 아카이빙 도메인 자료 업로드 API 기능구현 pr입니다.

👾 작업 내용

  • 프로젝트 등록 API 기능구현
  • 자료 업로드 API 기능구현
  • 로그인 리졸버 등록 및 인증, 인가 기능구현

📸 스크린샷


스크린샷 2023-10-14 오후 9 45 56

🎸 기타 사항

  • x

@dangnak2 dangnak2 added the 🔮 Feat 기능을 생성해요 ! label Oct 14, 2023
@dangnak2 dangnak2 self-assigned this Oct 14, 2023
Copy link
Member

@chaerlo127 chaerlo127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셧슴다 리뷰 확인 부탁

String token = webRequest.getHeader(Constants.JWT.AUTHORIZATION_HEADER);
if(!StringUtils.hasText(token)) throw new BaseException(BaseResponseCode.NULL_TOKEN);
// 추출
token = token.replace(Constants.JWT.BEARER_PREFIX, "");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 썼다가 에러 나서 replace 대신에 subString으로 변경해주세유

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace를 썼을 때 에러나는 이유가 무엇인가요?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지난번 다음과 같은 에러를 뱉어내어 확인해보니 파싱할 때 대체로 subString을 사용하더라구요

nested exception is io.jsonwebtoken.io.DecodingException: Illegal base64url character: ' ']

Copy link

@leeseunghakhello leeseunghakhello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다

secret: ENC(7JHqgwmXfXySGksMK5SOUrWg7edAhDXA044D8pyPbQbsYgdgs+by47ti/tHUwlwqSCMmmD9FM3tZvazmb/0wtqTKqYXGsrNnlkD2yFO11Z6Gis49IO0SWhaAnmyUexlwy+Bscc2pZBK12M50vCeHkFQGRIe1SlPj)

aws:
s3:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추후에 WAS에 s3 빼봅시다

Copy link
Member

@sojungpp sojungpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고독한아카이빙 수고하셨습니단

.project(project)
.user(user)
.build();
project.addMaterial(material);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

project.addMaterial(material);
이 코드는 어떤 로직이에여 ?

Copy link
Member

@sojungpp sojungpp Oct 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 양방향매핑 때문이면 별도로 추가 안 해줘도 알아서 조회하는걸로 알고 있는디 !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

프로젝트와 자료 연관관계 맺는 로직인데 수정이 필요할것같아요!

@dangnak2 dangnak2 merged commit 9f64760 into develop Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 Feat 기능을 생성해요 !
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants