Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useFileLogger #111

Merged
merged 2 commits into from
Jan 31, 2022
Merged

useFileLogger #111

merged 2 commits into from
Jan 31, 2022

Conversation

bung87
Copy link
Contributor

@bung87 bung87 commented Jan 30, 2022

PMunch
PMunch requested changes Jan 30, 2022
View reviewed changes
Copy link
Owner

@PMunch PMunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good , but please see the comments I left

src/nimlsp.nim Show resolved Hide resolved
src/nimlsp.nim
let frame = await ins.readFrame
debugEcho "Got frame:\n" & frame
debugLog "Got frame:"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit strange that these are two separate log levels

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use debug level output debug sentence , info level for raw payload , it's pretty to me.

src/nimlsppkg/baseprotocol.nim Outdated Show resolved Hide resolved
src/nimlsppkg/logger.nim Outdated Show resolved Hide resolved
src/nimlsppkg/logger.nim Outdated Show resolved Hide resolved
@bung87
Copy link
Contributor Author

bung87 commented Jan 31, 2022

please merge this one first , rest PRs may relys on this , since it changes debug log proc.

@PMunch PMunch merged commit 4a577ca into PMunch:master Jan 31, 2022
@williamboman williamboman mentioned this pull request Feb 7, 2022
Closed
1 task
muxueqz pushed a commit to muxueqz/nimlsp that referenced this pull request Mar 1, 2022
@bung87 @muxueqz
useFileLogger (PMunch#111)
658c662 
* use file logger

* code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PMunch PMunch PMunch requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bung87 @PMunch