Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Visible Device Name" color white for easier viewing #44

Closed
richtj999 opened this issue Mar 6, 2023 · 3 comments
Closed

Make "Visible Device Name" color white for easier viewing #44

richtj999 opened this issue Mar 6, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@richtj999
Copy link

Is your feature request related to a problem? Please describe.
I am having a hard time seeing the visible device name text in black on the black fire remote

Describe the solution you'd like
I tried to change the color from black to white in the JS file which didnt work and also tried to add text into the card

Describe alternatives you've considered
primary-background-color: '#FFFFFF'
secondary-background-color: '#FFFFFF'
table-row-background-color: '#FFFFFF'
table-row-alternative-background-color: '#FFFFFF'
visible_name_text: Den
primary-text-color: '#FFFFFF'
secondary-text-color: '#FFFFFF'

Additional context
I didnt get an error from the above but it didnt work either (the text color change).

The card is great! Love it!

I was using something else and the only nice thing i could do with it that I am struggling with on your card is pointing the volume controls to the TV direct

Similar to:
volume_down:
service: media_player.volume_down
data:
entity_id: media_player.maindensam
volume_up: null
service: media_player.volume_up
data: {}
target:
entity_id: media_player.maindensam
volume_mute:
service: media_player.volume_mute
service_data:
command: volume_mute
entity_id: media_player.maindensam

@PRProd PRProd added the enhancement New feature or request label Mar 6, 2023
@PRProd
Copy link
Owner

PRProd commented Mar 6, 2023

@richtj999 - As of right now, there isn't a mechanism for you to choose your own color for the device label. I intentionally chose black as the default color to match the aesthetic of the remote control - to make the name look engraved like the Amazon Fire logo. I understand that it's not always the easiest to read, (form over function) so I'm going to keep this issue open until I'm able to provide the ability for you to choose your own color.


In regards to this:

I was using something else and the only nice thing i could do with it that I am struggling with on your card is pointing the volume controls to the TV direct

There is a way to do this with the Firemote card right now. Full instructions can be found in the README.md file under the Button Overrides heading. There was a discussion in the past ( #6 ) about adding this functionality in a way similar to what you were trying to do, but I have not built that yet since the script feature has been a reasonable workaround in the meantime.

@PRProd PRProd self-assigned this Mar 6, 2023
PRProd added a commit that referenced this issue Mar 17, 2023
v2.0.0-beta1

Here is a list of the NVIDIA Shield models currently available to the
public: (let me know if I'm missing one)
 - Shield TV Pro (2019)
 - Shield TV (2019)
 - Shield TV Pro (2017)
 - Shield TV (2017)
 - Shield TV Pro (2015)
 - Shield TV (2015)

- Remote Style Override: Regardless of the kind of device you own, you
can switch your Firemote card to look like a completely different remote
control.  If you were very clever, you probably knew of a way to do this
already, but now it's built in!
- Visible Device Name Color Choice: As requested in #44, you can now
choose a different color for the visible device name text.  As of right
now, it should work properly on any Amazon style remote, but it is not
yet ready for the Shield version.
- Sometimes apps made for the Amazon Fire world weren't the same as the
apps made for other Android TV style devices which needed to be sorted
out.  If you've used Firemote for any non Amazon Fire devices, you may
have come across this problem before, as @moh-Brent discovered in #30.
These issues have been all sorted out under the hood which will
absolutely result in a better experience

- Navigation via the dpad is sllloooowwww.  While I recognize that this
is the common experience for anyone who has been using Firemote with a
Shield device in 'Strong' compatibility mode, I really want to fix it.
So far, lots of research, no positive results.
- Support for the visible device name feature on an Shield remote has
not been completed, so attempting to use it now will completely kill the
layout of an NVIDIA style remote
@PRProd
Copy link
Owner

PRProd commented Mar 17, 2023

This new functionality has been added in the recent pre-release version(s). I will keep this open until the official release.

PRProd added a commit that referenced this issue Mar 21, 2023
NVIDIA Shield Support Release

New features
 - Native support for NVIDIA Shield devices!
- Remote Style Override: Regardless of the kind of device you own, you
can switch your Firemote card to look like a completely different remote
control.  If you were very clever, you probably knew of a way to do this
already, but now it's built in!
 - Visible Device Name Color Choice: As requested in #44, you can now
choose a different color for the visible device name text.  As of right
now, it should work properly on any Amazon style remote, but it is not
yet ready for the Shield version.
 - Sometimes apps made for the Amazon Fire world weren't the same as the
apps made for other Android TV style devices which needed to be sorted
out.  If you've used Firemote for any non Amazon Fire devices, you may
have come across this problem before, as @moh-Brent discovered in #30.
These issues have been all sorted out under the hood which will
absolutely result in a better experience

New App Shortcuts
 - OQEE by Free #39
 - TiVimate #32, #48
 - SmartTubeNext (STN) #48
 - Sky News #49
 - IPVanish #49
 - VTM GO (BE) #50
 - Streamz (BE) #50
 - VRT MAX (BE) #50
 - Freevee

I'd like to give a HUGE thank you to @MRobi1 & @jrspowers for their help
as beta testers! #47
@PRProd
Copy link
Owner

PRProd commented Mar 21, 2023

This functionality exists now in the newest release: v2.0.0

Enjoy!

Join the discussion #52

@PRProd PRProd closed this as completed Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants