Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devops: Don't auto-install brew deps #3346

Merged
merged 13 commits into from
Aug 19, 2023
Merged

devops: Don't auto-install brew deps #3346

merged 13 commits into from
Aug 19, 2023

Conversation

max-sixty
Copy link
Member

@max-sixty max-sixty commented Aug 15, 2023 •
edited
Loading

As discussed in #3333 (comment)

(need to have another look in the morning)

eitsupi
eitsupi reviewed Aug 15, 2023
View reviewed changes
Taskfile.yml Outdated Show resolved Hide resolved
@max-sixty
Copy link
Member Author

max-sixty commented Aug 15, 2023 •
edited
Loading

Having some trouble with the devcontainer...

This last passed two weeks ago.

I know you're keen on not running this too often, but I do wonder whether running this nightly would help us understand the cause when we get a problem like this — is it the parent image? Is it cargo binstall? I'm not sure the best way to figure this out...

I added a fallback to installing from source here, but now the binaries aren't installed to the PATH: https://github.com/PRQL/prql/actions/runs/5870585733/job/15917918066?pr=3346#step:6:1016

max-sixty added a commit to max-sixty/prql that referenced this pull request Aug 19, 2023
@max-sixty
ci: Try splitting devcontainer job
aaeca53 
Hopefully get at least one platform passing. Ref the comment at PRQL#3346 (comment)
@max-sixty max-sixty mentioned this pull request Aug 19, 2023
Merged
max-sixty
max-sixty commented Aug 19, 2023
View reviewed changes
Taskfile.yml Outdated Show resolved Hide resolved
max-sixty
max-sixty commented Aug 19, 2023
View reviewed changes
Taskfile.yml Outdated Show resolved Hide resolved
@max-sixty
Copy link
Member Author

Merging this despite the devcontainer failure — it's unrelated.

@max-sixty max-sixty enabled auto-merge (squash) August 19, 2023 18:42
@max-sixty max-sixty merged commit ae7831a into PRQL:main Aug 19, 2023
45 of 47 checks passed
@max-sixty max-sixty deleted the taskfile branch August 19, 2023 18:50
@max-sixty
Copy link
Member Author

is it the parent image? Is it cargo binstall? I'm not sure the best way to figure this out...

Looks like that issue is related to cargo-bins/cargo-binstall#1292

@max-sixty max-sixty mentioned this pull request Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eitsupi eitsupi eitsupi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-sixty @eitsupi