Make the LicensesDialogFragment's licenses text styleable #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hameno
requested changes
Mar 12, 2017
pom.xml
Outdated
|
|
||
| <!-- Dependency Versions --> | ||
| <junit.version>4.12</junit.version> | ||
| <robolectric.version>3.0</robolectric.version> | ||
| <android.version>6.0_r3</android.version> | ||
| <android-support.version>23.3.0</android-support.version> | ||
| <android.version>4.1.1.4</android.version> |
There was a problem hiding this comment.
this should be 7.1.1_r3 when android.sdk.platform is 25
| android:text="@string/single" | ||
| android:onClick="onSingleClick" | ||
| android:layout_weight="1" /> | ||
| android:layout_height="match_parent"> |
There was a problem hiding this comment.
the child inside a scrollview should use wrap_content for height
hameno
reviewed
Mar 12, 2017
| } | ||
|
|
||
| private String getRGBAString(@ColorInt int color) { | ||
| return "background-color: rgba(" + Color.red(color) + "," + Color.green(color) + "," + Color.blue(color) + "," + ((float) Color.alpha(color) / 255) + ");"; |
There was a problem hiding this comment.
please use String.format for this
|
@hameno Please check again. |
hameno
approved these changes
Mar 12, 2017
|
Hi @hameno , will this pr be merged and release in next time? |
|
Hey, yes, hopefully I have some time this weekend to do a release. |
|
I hope so. |
|
1.8.2 is now released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the default css style is too bright in night mode, so I make the LicensesDialogFragment's licenses text can be styled.