Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting allowed image qualities #20

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Support setting allowed image qualities #20

merged 1 commit into from
Jan 27, 2020

Conversation

steviki
Copy link
Contributor

@steviki steviki commented Jan 27, 2020

Details

This PR adds support for setting allowedImageQualities

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json and plugin.xml(see example commit: 09d5c6b).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/PSPDFKit-Cordova/releases).
  • Locally, pull the latest master and publish (npm publish) the new release to npm.

@steviki steviki added enhancement New feature or request ios labels Jan 27, 2020
radazzouz
radazzouz approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@radazzouz radazzouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@steviki steviki merged commit b0b5486 into master Jan 27, 2020
@steviki steviki deleted the stefan/allowed-image-qualities branch January 27, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radazzouz radazzouz radazzouz approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request ios READY FOR REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steviki @radazzouz