Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to PSPDFKit 7 for Android #47

Merged
merged 3 commits into from
Jul 23, 2021
Merged

Upgrade to PSPDFKit 7 for Android #47

merged 3 commits into from
Jul 23, 2021

Conversation

simoarpe
Copy link
Contributor

@simoarpe simoarpe commented Jul 21, 2021 •
edited by radazzouz
Loading

Details

  • Changes pspdfkitVersion to version 7

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json and plugin.xml(see example commit: 09d5c6b).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/PSPDFKit-Cordova/releases).
  • Locally, pull the latest master and publish (npm publish) the new release to npm.

@simoarpe simoarpe self-assigned this Jul 21, 2021
radazzouz
radazzouz approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@radazzouz radazzouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@radazzouz radazzouz self-requested a review July 22, 2021 14:35
@davidschreiber davidschreiber changed the title Upgrade to Android 7 Upgrade to PSPDFKit 7 for Android Jul 22, 2021
@radazzouz radazzouz requested review from radazzouz and removed request for radazzouz July 22, 2021 19:14
@radazzouz radazzouz self-assigned this Jul 23, 2021
radazzouz
radazzouz approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@radazzouz radazzouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I tested the Cordova and Ionic example projects on Android and iOS and they work fine.

I also tested the integration using this branch into newly created Cordova and Ionic projects on Android and iOS.

steviki
steviki approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@steviki steviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Verified that both, the Cordova and the Ionic examples on Android and iOS work fine, when following the steps in the documentation.

@radazzouz radazzouz merged commit 1666c21 into master Jul 23, 2021
@radazzouz radazzouz deleted the simone/upgrade-to-android-7 branch July 23, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steviki steviki steviki approved these changes

@radazzouz radazzouz radazzouz approved these changes

@davidschreiber davidschreiber Awaiting requested review from davidschreiber

Assignees

@simoarpe simoarpe

@radazzouz radazzouz

Labels
android READY FOR REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simoarpe @steviki @radazzouz