Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.5.2 and update plugin to support iOS 14+ #55

Merged
merged 5 commits into from
May 31, 2022
Merged

Release 1.5.2 and update plugin to support iOS 14+ #55

merged 5 commits into from
May 31, 2022

Conversation

steviki
Copy link
Contributor

@steviki steviki commented May 31, 2022 •
edited
Loading

Details

This PR bumps the deployment target to iOS 14+, as PSPDFKit 11.4 for iOS only supports iOS 14 and up.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json and plugin.xml(see example commit: 09d5c6b).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/PSPDFKit-Cordova/releases).
  • Locally, pull the latest master and publish (npm publish) the new release to npm.

nishantdesai
nishantdesai approved these changes May 31, 2022
View reviewed changes
Copy link

@nishantdesai nishantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peachy 👌!

@steviki steviki changed the title Update plugin to support iOS 14+ Release 1.5.2 and update plugin to support iOS 14+ May 31, 2022
@steviki steviki merged commit a715cd5 into master May 31, 2022
@steviki steviki deleted the stefan/ios-14-and-up-support branch May 31, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishantdesai nishantdesai nishantdesai approved these changes

Assignees
No one assigned
Labels
ios READY FOR REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steviki @nishantdesai