Skip to content

Commit

Permalink
docu update (#214)
Browse files Browse the repository at this point in the history
  • Loading branch information
ckolbPTB authored Mar 13, 2024
1 parent caa89eb commit 4332865
Show file tree
Hide file tree
Showing 5 changed files with 32 additions and 17 deletions.
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ This package supports ismrmrd-format for MR raw data. All data containers utiliz
If you want to give MRpro a try you can use
[![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/PTB-MR/mrpro.git/main?labpath=examples)

You find the documentation [here](https://ptb-mr.github.io/mrpro/)

## Contributing

### Installation for developers
Expand All @@ -27,8 +29,7 @@ We recommend to use [Microsoft Visual Studio Code](https://code.visualstudio.com

A list of recommended extensions for VSCode is given in the [.vscode/extensions.json](.vscode\extensions.json)

### Naming Convention
We try to follow the [pep8](https://peps.python.org/pep-0008/) naming convention (e.g., all lowercase variable names, CapWords class names). We deviate for the names of source code file names containing a single class. These are named as the class.

We try to use descriptive variable names when applicable (e.g., "result" instead of "res", "tolerance_squared" instead of "sqtol", "batchsize" instead of "m"). A name starting with "n_" is used for variables describing a number of... (e.g., "n_coils" instead of "ncoils" or "num_coils"), variable names ending with "_op" for operators (e.g., "fourier_op"). We use "img" as a variable name for images.
### Documentation

Please have a look at our [contributor guide](https://ptb-mr.github.io/mrpro/contributor_guide.html) for more information on the structure of the repository, naming conventions and other useful information.
22 changes: 19 additions & 3 deletions docs/source/contributor_guide.rst
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
============================
Guide for MRPro Contributors
============================
======================
Guide for Contributors
======================

Repo structure
==============
Expand Down Expand Up @@ -62,3 +62,19 @@ src/mrpro structure
**utils**
Utilities such as spatial filters and also more basic functionality such as applying functions serially along the
batch dimension (``smap``).


Naming convention
=================
We try to follow the [pep8](https://peps.python.org/pep-0008/) naming convention (e.g., all lowercase variable names,
CapWords class names). We deviate for the names of source code file names containing a single class.
These are named as the class.

We try to use descriptive variable names when applicable (e.g., ``result`` instead of ``res``, ``tolerance_squared`` instead
of ``sqtol``, ``batchsize`` instead of ``m``).

A name starting with ``n_`` is used for variables describing a number of... (e.g., ``n_coils`` instead of ``ncoils`` or
``num_coils``), variable names ending with ``_op`` for operators (e.g., ``fourier_op``). We use ``img`` as a variable name
for images.


4 changes: 2 additions & 2 deletions docs/source/examples.rst
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
MRPro Examples
==============
Examples
========

Notebooks with examples of how you can use MRpro.
All of the notebooks can directly be run via binder or colab from the repo.
Expand Down
10 changes: 4 additions & 6 deletions docs/source/index.rst
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
.. MRPro documentation master file, created by
sphinx-quickstart on Sun Oct 15 09:52:11 2023.
You can adapt this file completely to your liking, but it should at least
contain the root `toctree` directive.
.. MRPro documentation
Welcome to MRPro's documentation!
=================================
Expand All @@ -10,10 +7,11 @@ Welcome to MRPro's documentation!
:maxdepth: 1

user_guide
faq
contributor_guide
examples
faq
api
contributor_guide




Expand Down
6 changes: 3 additions & 3 deletions docs/source/user_guide.rst
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
=====================
Guide for MRPro Users
=====================
===============
Guide for Users
===============

MRpro is a MR image reconstruction and processing framework specifically developed to work well with pytorch.
The data classes utilize torch tensors for storing data such as MR raw data or reconstructed image data.
Expand Down

0 comments on commit 4332865

Please sign in to comment.