Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priceavail #7

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Priceavail #7

merged 5 commits into from
Oct 4, 2023

Conversation

ammopt
Copy link
Member

@ammopt ammopt commented Oct 4, 2023

No description provided.

Build the ArticleShelf_CheckAvailability payload:
For each $id_to_check received from the backend, add a new <citation>
XML element with either the DOI or PubmedID.

An example of a well-formed XML payload is:
<ArticleShelf_CheckAvailability xmlns="http://reprintsdesk.com/webservices/">
  <inputXmlNode>
    <input schemaversionid="1">
      <citations xmlns="">
        <citation>
          <doi><![CDATA[10.1680/muen.2010.163.4.257]]></doi>
        </citation>
        <citation>
          <doi><![CDATA[10.1061/ajrua6.0000905]]></doi>
        </citation>
        <citation>
          <pmid><![CDATA[8232696]]></pmid>
        </citation>
        <citation>
          <doi><![CDATA[10.1680/jener.21.00116]]></doi>
        </citation>
        <citation>
          <doi><![CDATA[10.4018/ijsesd.292073]]></doi>
        </citation>
        <citation>
          <doi><![CDATA[10.1353/gpr.2022.0004]]></doi>
        </citation>
        <citation>
          <doi><![CDATA[10.1068/a42503]]></doi>
        </citation>
      </citations>
    </input>
  </inputXmlNode>
</ArticleShelf_CheckAvailability>

The xmlns='' is required or the webservice fails on RPDesk's end
Some webservices return xmlData, others return outputXmlNode.
All previous utilized ReprintsDesk webservices returned 'xmlData',
but the new ArticleShelf_CheckAvailability returns 'outputXmlNode'

Additionally, Order_GetPriceEstimate2 returns xmlOutput
so we update to satisfy that.
@mrenvoize
Copy link
Member

All looks good to me.. though every time I'm reminded we're using that Smart library as well as XML::LibXML it bugs me.. really wish I had the time/expertise to work on shlomif/perl-XML-LibXML#67 and drop our extra dependancy.

@mrenvoize mrenvoize merged commit 9017a66 into master Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants