Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ftp): List empty directory #23638

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

plichard
Copy link

@plichard plichard commented Sep 2, 2024

Solved Problem

When trying to list an empty directory, I found that the mavlink ftp implementation does not return EOF.

Solution

payload->offset == 0 should be checked as well for EOF.
This also changes the behavior to return kErrFailErrno when retrieving a dir entry fails, instead of failing silently (while removing duplicated payload->size and closedir logic).

Changelog Entry

For release notes:

Bugfix mavlink ftp not returning EOF on empty directory list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant