fix(ftp): List empty directory #23638
Open
+3
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
When trying to list an empty directory, I found that the mavlink ftp implementation does not return EOF.
Solution
payload->offset == 0
should be checked as well for EOF.This also changes the behavior to return
kErrFailErrno
when retrieving a dir entry fails, instead of failing silently (while removing duplicatedpayload->size
andclosedir
logic).Changelog Entry
For release notes: