Fix output of param show -q XXX on NuttX shell #23793
Open
+27
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
When using e.g.
param show -q SYS_AUTOSTART
on the NuttX shell I found that it actually doesn't output anything. After looking into the code it prints the same way as otherparams show
variants but without any newline.Solution
fflush(stdout);
instead of a newline which also works. But adding the newline should be ok since the standard says trailing newlines get stripped from shell substitutions so we stick with the newline.PARAM_PRINT
defines.Changelog Entry
Test coverage
I tested on
fmu-v5x
and the parameters show on the MAVLink shell.SITL SIH still loads, the startup script uses the substitution:
PX4-Autopilot/ROMFS/px4fmu_common/init.d-posix/rcS
Line 209 in da88278