Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mode_req_local_alt from Descend mode and handle it in FW position controller #23840

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sfuhrer
Copy link
Contributor

@sfuhrer sfuhrer commented Oct 22, 2024

Solved Problem

I recently crashed a VTOL vehicle in FW after disabling both GPS and baro fusion in air, which made it switch from AUTO to TERMINATE mode.

Solution

  • remove mode requirement for a valid altitude estimate from DESCEND
  • similar to what is done for MC handle invalid v/vz in the FW position controller. For FW we in case of invalid v/vz measurements would likely just want the thrust to be 0, such that the vehicle glides down to the ground while still tracking the loiter (assuming it doesn't stall).

Changelog Entry

For release notes:

Improvement: Remove mode_req_local_alt from Descend mode and handle it in FW position controller

Test coverage

Can be easily tested in SITL: Disable Baro fusion (EKF2_BARO_CTRL), then takeoff in auto mode, then disable GPS fusion --> with current main it goes to Termination mode, with this PR to Descend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant