Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.15] Kill gesture docs #3316

Merged
merged 5 commits into from
Oct 10, 2024
Merged

[v1.15] Kill gesture docs #3316

merged 5 commits into from
Oct 10, 2024

Conversation

hamishwillee
Copy link
Collaborator

This add docs and release note for the kill gesture added in PX4/PX4-Autopilot#18509.

@MaEtUgR Can you please sanity check this. I am assuming, for example, that this applies to all frame types.

FWIW I think the difference between disarm, kill, and flight termination need to be clarified. My understanding is that

  • arm - means powered and enabled.
  • disarm - means motors unpowered (and by definition disabled)
  • "kill" means turn off the motors, but you're still armed - so motors are powered but disabled.
  • "flight termination" means motors are turned off but other outputs locked to certain values - so this is like kill but you also might deploy a parachute.

Is that about right? The reason I find it confusing is that there are so many things that seem to achieve "kind of" the same thing. As a user, should I disarm? Should I kill? Should I flight terminate? Why? When?

To me kill and disarm previously meant recoverable and unrecoverable motors off. Now you've added a kill gesture that isn't recoverable I don't know why you wouldn't just disarm? Then why not a flight termination switch so I can deploy a parachut.?

  • When this goes in, push to main too.

@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-v1-15-public-changes-what-needs-docs/39850/5

@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-v1-15-public-changes-what-needs-docs/39850/1

@hamishwillee
Copy link
Collaborator Author

@MaEtUgR Can you please sanity check this?

Copy link
Member

@MaEtUgR MaEtUgR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, totally fell through the cracks. Thanks for taking care of documenting this feature! 🙏
I think I only found a small copy paste error or a detail I don't understand.

en/config/safety.md Outdated Show resolved Hide resolved
@hamishwillee hamishwillee merged commit ae7c57c into v1.15 Oct 10, 2024
1 check passed
@hamishwillee hamishwillee deleted the kill_gesture_115 branch October 10, 2024 20:50
Copy link

/en/releases/1.15.md

hamishwillee added a commit that referenced this pull request Oct 10, 2024
* Kill gesture docs

* Add release note

* Update en/config/safety.md

Co-authored-by: Matthias Grob <[email protected]>

* Prettier

---------

Co-authored-by: Matthias Grob <[email protected]>
@hamishwillee hamishwillee mentioned this pull request Oct 10, 2024
hamishwillee added a commit that referenced this pull request Oct 10, 2024
* Kill gesture docs

* Add release note

* Update en/config/safety.md



* Prettier

---------

Co-authored-by: Matthias Grob <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants