Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXP MR-VMU-RT1176 flightcontrol upate #3398

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Oct 2, 2024

This replaces #3397 which would not accept subedits. FYI @dk7xe @mrpollo and @igalloway

@dk7xe I had to create this because your branch wasn't editable (by me).
The main changes are editorial - I found the introduction a bit confusing so I have moved some bits around. I think it now makes things a bit more clear that this is reference design board consisting of a carrier and an FMU.

I also

  • made the images bigger.
  • Made the discontinued markup work properly for the older board. It is still manufacturer supported, but it moves out of that page because it is better for users to not consider discontinued boards when selecting. If they open the board page they will see it is discontinued.
  • Retitled to "NXP MR-VMU-RT1176 Flight Controller". Adding Flight Controller makes it obvious what we're talking about in searches etc.
  • Either hid TBDs or replaced with "Use this". There is no need to expose that it is TBC, particularly for the wiring diagram when the wiring is largely the same as other pixhawk-connector standard FCs.

@dk7xe @igalloway

  • This is available now?
  • Is it true that you can install firmware with current release QGC and PX4 v1.15? Does it work with earlier versions? We should say.
  • It would be good to have a link to the FMUv6X-RT open standard since this is mentioned several times. Do we have one?

@hamishwillee
Copy link
Collaborator Author

FYI what I normally do is create a branch for my edits rather than push up my main branch. So assuming your repo is origin and the PX4 repo is upstream, I'd start my work like this:

# get main to match upstream
git checkout main
git fetch upstream main
git pull upstream main

# Branch to a sensible name other than main
git checkout -b pr_something
# Do work, add commits
#Perhaps rebase against upstream again
git fetch upstream main
git rebase upstream/main

# push changes 
git push upstream pr_something

# or
git push origin pr_something

This means you can do whatever you like on main

@dk7xe
Copy link
Contributor

dk7xe commented Oct 3, 2024

@hamishwillee

  • there are 147 boards on the way from Holybro to our WHS. Release in coming weeks.
  • the FMU is supported by PX4 since 1.15 only. FMU is supported in QGC and can be flashed the usual way via Firmway update in QGC.
  • the Pixhawk 6X-RT standard document is reworked at the moment and should be ready end of next week.

@mrpollo mrpollo self-requested a review October 3, 2024 16:51
Copy link
Contributor

@mrpollo mrpollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its looking pretty good, i just left a few comments

en/flight_controller/autopilot_manufacturer_supported.md Outdated Show resolved Hide resolved
:::

:::tip
This autopilot reference design is [supported](../flight_controller/autopilot_manufacturer_supported.md) by NXP.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see above comment


## Assembly/Setup

Wiring is similar to the [Holybro Pixhawk 6X](../flight_controller/pixhawk6x.md#connections) and other boards that follow the [Pixhawk Connector Standard](https://github.com/pixhawk/Pixhawk-Standards/blob/master/DS-009%20Pixhawk%20Connector%20Standard.pdf).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although it is similar to holybros, the key selling point for NXP is the addition of ports, so I suggest NXP invest in creating a wiring diagram

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dk7xe This makes sense to me, though how important this is does depend on how likely this reference design is likely to match the derivatives.

@mrpollo makes a very good point though - I wasn't even aware that the new ports were "significant" from the current documentation. To me this was mostly about the reference design benefits. So if the ports are a key difference, that would be good to capture?
I suggest that if you agree you do this as a github suggestion.

@hamishwillee
Copy link
Collaborator Author

I can move it to Pixhawk standard next week, add v1.15 markup, and cross link the standard - is it likely to be ready by Tuesday?

dk7xe and others added 22 commits October 10, 2024 14:45
	new file:   assets/flight_controller/nxp_mr-vmu-rt1176/mr-vmu-rt1176_front.jpg
	new file:   assets/flight_controller/nxp_mr-vmu-rt1176/mr-vmu-rt1176_left.jpg
	new file:   assets/flight_controller/nxp_mr-vmu-rt1176/mr-vmu-rt1176_right.jpg
	new file:   assets/flight_controller/nxp_mr-vmu-rt1176/mr-vmu-rt1176_top.jpg
	new file:   assets/flight_controller/nxp_mr-vmu-rt1176/mr-vmu-rt1176_upleft.jpg
	modified:   en/flight_controller/autopilot_manufacturer_supported.md
	new file:   en/flight_controller/nxp_mr-vmu-rt1176.md

This adds documentation of NXP MR-VMU-RT1176 flightcontrol (Pixhawk 6X-RT derivate with just NXP secific baseboard).
formatting improved
formatting improved (2)
add note on wiring diagram showing Pixhawk 6X-RT
Minor edits to wording.
Change reference to being reference design and EVK with volume by 3rd parties.
added links to basboard connector NXP gitbook
AOK with this change

Co-authored-by: Ramon Roche <[email protected]>
AOK with this change

Co-authored-by: Ramon Roche <[email protected]>
agreed to remove link for now. Will add new Standard when released

Co-authored-by: Ramon Roche <[email protected]>
	modified:   en/SUMMARY.md
	modified:   en/_sidebar.md
	modified:   en/flight_controller/nxp_mr-vmu-rt1176.md

- Added VMU-RT1176 to flight controller section on summary and sidebar.
- Moved FMUK66 to discontinued section on summary and sidebar.
- Reworked nxp_mr-vmu-rt1176.md according comments from 'Add NXP MR-VMU-RT1176 flightcontrol #3394'

This section provides information about how to choose the flight controller, mount it, upload firmware (replacing an incompatible bootloader if needed), and configure its orientation.
## Selecting a Flight Controller
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, too many lists of FCs. I removed the one below and now link to it

Copy link

No flaws found

@hamishwillee
Copy link
Collaborator Author

OK, I have made this "pixhawk standard" and added a v1.15 version badge. Also did some structural changes that you don't particularly need to worry about.

This is waiting on response to #3398 (comment) , and presumably linking information for the new board.

@hamishwillee
Copy link
Collaborator Author

@dk7xe Is the info for the new board published yet? @mrpollo had a comment for you in #3398 (comment) too.

Otherwise this is good to go.

@dk7xe
Copy link
Contributor

dk7xe commented Oct 16, 2024

@hamishwillee the DS20 standard on 6 X-RT is not out yet. We are working on the remaining parts.
@mrpollo i messaged you on discord regarding DS020

@hamishwillee
Copy link
Collaborator Author

@hamishwillee the DS20 standard on 6 X-RT is not out yet. We are working on the remaining parts. @mrpollo i messaged you on discord regarding DS020

Thanks. I'll wait on you all then. I do think that the "special value" of this board needs to be highlighted - the extra ports are not even mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants