-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote id info - subedited #3404
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With main and versions after v1.15 we will have support for remote ID over DroneCAN.
hamishwillee
commented
Oct 10, 2024
hamishwillee
commented
Oct 10, 2024
hamishwillee
commented
Oct 10, 2024
hamishwillee
commented
Oct 10, 2024
@Aaron1356 OK, so just one open issue #3404 (comment) Any idea with the remote ID pr this is conditional on is expected to merge? |
2 tasks
No flaws found |
@Aaron1356 I've merged this on top of @julianoes PR. I think it works well. Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not be merged in until after the Remote ID base information is merged int located here:
This just adds in some information about how to see that Remote ID over can is working properly and how to get QGC setup so that others don't run into the same issue that I did.
FYI @Aaron1356 This replaces #3402 which I couldn't subedit.