Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Add .pre-commit-hooks.yaml #159

Merged
merged 4 commits into from
Apr 17, 2021
Merged

[MNT] Add .pre-commit-hooks.yaml #159

merged 4 commits into from
Apr 17, 2021

Conversation

dougthor42
Copy link
Contributor

This adds .pre-commit-hooks.yaml to the root of the repo so that people can use this project without having to install sql_formatter into their own environment (pre-commit will install it into it's internal virtual env).

Eg: lets users do this:

repos:
  - repo: https://github.com/PabloRMira/sql_formatter
    rev: master
    hooks:
    - id: sql_formatter

@PabloRMira PabloRMira self-requested a review April 14, 2021 19:55
@PabloRMira
Copy link
Owner

Looks really cool! Thank you very much for your contribution @dougthor42 !

In order for me to not get conflicts later: Could you please rather edit the nbs/index.ipynb instead of the README directly and then populate the index into the README via make prepush?

The reason is that I use the nbdev framework for the development of this project and otherwise I will get conflicts later

I described the setup in detail under Contributing to the code basis

and the development workflow under Development Workflow

Thanks in advance!

@PabloRMira PabloRMira changed the title Add .pre-commit-hooks.yaml [MNT] Add .pre-commit-hooks.yaml Apr 14, 2021
@dougthor42
Copy link
Contributor Author

dougthor42 commented Apr 15, 2021

Wow, don't I feel foolish! I didn't read your contributing.md file 😨. Sorry about that...

I'll get things fixed asap.

@PabloRMira PabloRMira merged commit 99d2850 into PabloRMira:master Apr 17, 2021
@PabloRMira
Copy link
Owner

Thank you very much, @dougthor42 !

@dougthor42 dougthor42 deleted the pre-commit branch April 19, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants