Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump esbuild from 0.17.2 to 0.17.3 #319

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 19, 2023

⚠️ Dependabot is rebasing this PR ⚠️

Rebasing might not happen immediately, so don't worry if this takes some time.

Note: if you make any changes to this PR yourself, they will take precedence over the rebase.


Bumps esbuild from 0.17.2 to 0.17.3.

Release notes

Sourced from esbuild's releases.

v0.17.3

  • Fix incorrect CSS minification for certain rules (#2838)

    Certain rules such as @media could previously be minified incorrectly. Due to a typo in the duplicate rule checker, two known @-rules that share the same hash code were incorrectly considered to be equal. This problem was made worse by the rule hashing code considering two unknown declarations (such as CSS variables) to have the same hash code, which also isn't optimal from a performance perspective. Both of these issues have been fixed:

    /* Original input */
    @media (prefers-color-scheme: dark) { body { --VAR-1: [#000](https://github.com/evanw/esbuild/issues/000); } }
    @media (prefers-color-scheme: dark) { body { --VAR-2: [#000](https://github.com/evanw/esbuild/issues/000); } }
    /* Old output (with --minify) */
    @​media (prefers-color-scheme: dark){body{--VAR-2: #000}}
    /* New output (with --minify) */
    @​media (prefers-color-scheme: dark){body{--VAR-1: #000}}@​media (prefers-color-scheme: dark){body{--VAR-2: #000}}

Changelog

Sourced from esbuild's changelog.

0.17.3

  • Fix incorrect CSS minification for certain rules (#2838)

    Certain rules such as @media could previously be minified incorrectly. Due to a typo in the duplicate rule checker, two known @-rules that share the same hash code were incorrectly considered to be equal. This problem was made worse by the rule hashing code considering two unknown declarations (such as CSS variables) to have the same hash code, which also isn't optimal from a performance perspective. Both of these issues have been fixed:

    /* Original input */
    @media (prefers-color-scheme: dark) { body { --VAR-1: [#000](https://github.com/evanw/esbuild/issues/000); } }
    @media (prefers-color-scheme: dark) { body { --VAR-2: [#000](https://github.com/evanw/esbuild/issues/000); } }
    /* Old output (with --minify) */
    @​media (prefers-color-scheme: dark){body{--VAR-2: #000}}
    /* New output (with --minify) */
    @​media (prefers-color-scheme: dark){body{--VAR-1: #000}}@​media (prefers-color-scheme: dark){body{--VAR-2: #000}}

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [esbuild](https://github.com/evanw/esbuild) from 0.17.2 to 0.17.3.
- [Release notes](https://github.com/evanw/esbuild/releases)
- [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md)
- [Commits](evanw/esbuild@v0.17.2...v0.17.3)

---
updated-dependencies:
- dependency-name: esbuild
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@PacoVK PacoVK merged commit 1920c5c into main Jan 19, 2023
@PacoVK PacoVK deleted the dependabot/npm_and_yarn/esbuild-0.17.3 branch January 19, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant