转换规则 No. 10 #170

enkilee · 2023-07-14T06:03:43Z

PR Docs

PR APIs

paddle.signal.stft

paddle-bot · 2023-07-14T06:03:47Z

Thanks for your contribution!

paconvert/api_mapping.json

zhwesky2010 · 2023-07-14T07:37:13Z

单测未通过，也需要修复

enkilee · 2023-07-17T06:26:33Z

@zhwesky2010 AssertionError: API (torch.stft): shape mismatch, torch shape is (1, 9, 9), paddle shape is (1, 16, 9)
我在pytorch测试的结果是(1, 9, 9)，在aistudio相同数据的结果也是(1, 9, 9)。不知为什么这里是 (1, 16, 9)

paconvert/api_matcher.py

enkilee · 2023-07-25T02:15:54Z

@zhwesky2010
请问，这种要如何追问题？

2023-07-20 12:42:10   File "/workspace/a4bba61b-0eea-44b9-8d1b-5a4732f9836f/PaConvert/paconvert/../paconvert/transformer/basic_transformer.py", line 550, in visit_FunctionDef
2023-07-20 12:42:10     super(BasicTransformer, self).generic_visit(node)
2023-07-20 12:42:10   File "/root/anaconda3/lib/python3.10/ast.py", line 494, in generic_visit
2023-07-20 12:42:10     value = self.visit(value)
2023-07-20 12:42:10   File "/workspace/a4bba61b-0eea-44b9-8d1b-5a4732f9836f/PaConvert/paconvert/../paconvert/base.py", line 82, in visit
2023-07-20 12:42:10     node = super(BaseTransformer, self).visit(node)
2023-07-20 12:42:10   File "/root/anaconda3/lib/python3.10/ast.py", line 418, in visit
2023-07-20 12:42:10     return visitor(node)
2023-07-20 12:42:10   File "/root/anaconda3/lib/python3.10/ast.py", line 503, in generic_visit
2023-07-20 12:42:10     new_node = self.visit(old_value)
2023-07-20 12:42:10   File "/workspace/a4bba61b-0eea-44b9-8d1b-5a4732f9836f/PaConvert/paconvert/../paconvert/base.py", line 82, in visit
2023-07-20 12:42:10     node = super(BaseTransformer, self).visit(node)
2023-07-20 12:42:10   File "/root/anaconda3/lib/python3.10/ast.py", line 418, in visit
2023-07-20 12:42:10     return visitor(node)
2023-07-20 12:42:10   File "/workspace/a4bba61b-0eea-44b9-8d1b-5a4732f9836f/PaConvert/paconvert/../paconvert/transformer/basic_transformer.py", line 314, in visit_Call
2023-07-20 12:42:10     node_list = matcher.get_paddle_nodes(node.args, node.keywords)
2023-07-20 12:42:10   File "/workspace/a4bba61b-0eea-44b9-8d1b-5a4732f9836f/PaConvert/paconvert/../paconvert/base.py", line 397, in get_paddle_nodes
2023-07-20 12:42:10     new_code = self.generate_code(new_kwargs)
2023-07-20 12:42:10   File "/workspace/a4bba61b-0eea-44b9-8d1b-5a4732f9836f/PaConvert/paconvert/../paconvert/api_matcher.py", line 3170, in generate_code
2023-07-20 12:42:10     kwargs["onesided"],
2023-07-20 12:42:10 KeyError: 'onesided'

zhwesky2010

这个API能否用GenericMatcher实现，而且你的实现和文档的转写思路也不太一样，看看转写文档 https://github.com/PaddlePaddle/docs/pull/6007/files#diff-bdd744e44f42895f618539ba1fe51a96e211dd9558d0a2967a453fdb89eec160

你可以看下GenericMatcher的功能，其搭配的 kwargs_change、paddle_default_kwargs、unsupport_args 这些字段的功能

paconvert/api_matcher.py

zhwesky2010 · 2023-08-03T04:31:22Z

tests/test_stft.py

+    obj.run(pytorch_code, ["result"])
+
+
+def test_case_4():


单测case需要加一些，这个API参数很多，可以写七八个case

已加。CI已过，请有空审核

zhwesky2010 · 2023-08-18T08:24:40Z

paconvert/api_mapping.json

+    ],
+    "kwargs_change": {
+      "input": "x",
+      "return_complex": "onesided"


这两个参数不是对应的，需要针对return_complex单独处理下

zhwesky2010 · 2023-08-28T08:07:38Z

return_complex 时，可使用as_real、as_complex进行转换处理

enkilee · 2023-08-28T10:26:39Z

收到，我尽快处理，抱歉

enkilee · 2023-08-30T03:10:34Z

按照文档的说法，不知道我理解的对不对：
pytorch：
return_complex ： Changed in version 2.0: return_complex is now a required argument for real inputs, as the default is being transitioned to True.
也就是说，现在在pytorch中， return_complex 默认为true, 输入数据为实信号，而且是必须为true？
Deprecated since version 2.0: return_complex=False is deprecated, instead use return_complex=True
Note that calling torch.view_as_real() on the output will recover the deprecated output format.
如果把return_complex设置为false，则需要调用torch.view_as_real()把结果换成real形式展示输出。

在paddle中：
onesided (bool，可选) - 当输入为实信号时，选择是否只返回傅里叶变换结果的一半的频点值（输入信号和窗函数均为实数时，傅里叶变换结果具有共轭对称性）。如果输入的信号或者窗函数的数据类型是复数，则此时不能设置为 True。默认为 True；

也就是说，onesided为false时，输入的是复数，可是pytorch2.0的输入必须为实信号，所以paddle的onesided值只能是True吧。

zhwesky2010 · 2023-09-04T13:31:41Z

但你这个和映射文档中的参数映射对不上吧，麻烦检查下文档是不是有问题 https://github.com/PaddlePaddle/docs/blob/develop/docs/guides/model_convert/convert_from_pytorch/api_difference/ops/torch.stft.md

enkilee · 2023-09-05T08:35:41Z

收到，我把文档改下。

enkilee · 2023-09-05T09:05:44Z

No.10 的文档改了：
PaddlePaddle/docs#6164

zhwesky2010 · 2023-09-07T07:55:32Z

paconvert/api_mapping.json

+    ],
+    "kwargs_change": {
+      "input": "x",
+      "return_complex": "onesided"


这里把 return_complex 这个参数赋值给 onesided 这个参数，我觉得是不对的，这不是两个完全不同的参数吗？

如果认为 return_complex 已经废弃，且恒为True无其他影响，那就应该设置 "return_complex": ""，表示直接去掉该参数。

目前这个写法 "return_complex": "onesided" 是出于什么考虑对应两个不同的参数呢？

收到，已改

zhwesky2010 · 2023-11-01T06:54:05Z

tests/test_stft.py

+                            [-1.6092,  0.5419, -0.2993,  0.3195]])
+        n_fft = 4
+        win_length = 4
+        result = torch.stft(x, n_fft=n_fft, center=False, win_length=win_length, normalized=True, return_complex=True)


增加一下测试case：return_complex=False

zhwesky2010 · 2023-11-01T06:55:26Z

tests/test_stft.py

+                            [ 0.4907, -1.3948, -1.0691, -0.3132],
+                            [-1.6092,  0.5419, -0.2993,  0.3195]])
+        n_fft = 4
+        result = torch.stft(x, n_fft=n_fft, center=False, return_complex=True)


这四种情况需要都测到：

全部指定关键字

全部不指定关键字

改变关键字顺序

默认参数全部省略

enkilee added 7 commits July 12, 2023 15:32

fix

7220d31

fix

421082c

fix

94052b2

Merge branch 'master' into master

240c942

fix

932539b

remove stft

4f9fe54

add stft

f0514ae

paddle-bot bot added contributor External developers status: proposed labels Jul 14, 2023

fix

f19c1e9

zhwesky2010 reviewed Jul 14, 2023

View reviewed changes

paconvert/api_mapping.json Outdated Show resolved Hide resolved

luotao1 mentioned this pull request Jul 14, 2023

Pytorch-Paddle代码转换工具开源任务 #112

Closed

luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jul 14, 2023

luotao1 assigned luotao1, zhwesky2010 and ROckDog22 Jul 14, 2023

enkilee added 6 commits July 15, 2023 18:14

fix

8aece8b

fix

d290778

fix

af29221

fix

f211c16

fix

d4afe68

fix

305310d

zhwesky2010 reviewed Jul 18, 2023

View reviewed changes

paconvert/api_matcher.py Outdated Show resolved Hide resolved

paconvert/api_matcher.py Outdated Show resolved Hide resolved

enkilee added 4 commits July 18, 2023 17:17

fix

6b141f5

fix

5391062

fix

cc447a0

fix

16405d7

enkilee added 9 commits July 19, 2023 12:58

fix

a7bd400

fix

e014679

fix

567f49b

fix

ad58800

fix

68611af

fix

205a64d

fix

c7be7c7

fix

81708fb

fix

22ec03f

zhwesky2010 reviewed Jul 31, 2023

View reviewed changes

paconvert/api_matcher.py Outdated Show resolved Hide resolved

paconvert/api_matcher.py Outdated Show resolved Hide resolved

paconvert/api_matcher.py Outdated Show resolved Hide resolved

luotao1 unassigned ROckDog22 Jul 31, 2023

enkilee added 3 commits August 1, 2023 15:36

Merge branch 'master' into optest-stft

242b317

fix

1ecc4c5

fix

26dab40

zhwesky2010 reviewed Aug 3, 2023

View reviewed changes

enkilee added 2 commits August 7, 2023 14:51

add unitest

5b0e18e

add unittest

e678380

zhwesky2010 reviewed Aug 18, 2023

View reviewed changes

Merge branch 'PaddlePaddle:master' into optest-stft

4de4947

CI

e6483e4

zhwesky2010 reviewed Sep 7, 2023

View reviewed changes

Merge branch 'master' into optest-stft

6da74b8

zhwesky2010 reviewed Nov 1, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

转换规则 No. 10 #170

转换规则 No. 10 #170

enkilee commented Jul 14, 2023 •

edited

Loading

paddle-bot bot commented Jul 14, 2023

zhwesky2010 commented Jul 14, 2023

enkilee commented Jul 17, 2023 •

edited

Loading

enkilee commented Jul 25, 2023

zhwesky2010 left a comment •

edited

Loading

zhwesky2010 Aug 3, 2023

enkilee Aug 8, 2023

zhwesky2010 Aug 18, 2023 •

edited

Loading

zhwesky2010 commented Aug 28, 2023

enkilee commented Aug 28, 2023

enkilee commented Aug 30, 2023 •

edited

Loading

zhwesky2010 commented Sep 4, 2023 •

edited

Loading

enkilee commented Sep 5, 2023

enkilee commented Sep 5, 2023 •

edited

Loading

zhwesky2010 Sep 7, 2023 •

edited

Loading

enkilee Oct 20, 2023

zhwesky2010 Nov 1, 2023

zhwesky2010 Nov 1, 2023

转换规则 No. 10 #170

Are you sure you want to change the base?

转换规则 No. 10 #170

Conversation

enkilee commented Jul 14, 2023 • edited Loading

PR Docs

PR APIs

paddle-bot bot commented Jul 14, 2023

zhwesky2010 commented Jul 14, 2023

enkilee commented Jul 17, 2023 • edited Loading

enkilee commented Jul 25, 2023

zhwesky2010 left a comment • edited Loading

Choose a reason for hiding this comment

zhwesky2010 Aug 3, 2023

Choose a reason for hiding this comment

enkilee Aug 8, 2023

Choose a reason for hiding this comment

zhwesky2010 Aug 18, 2023 • edited Loading

Choose a reason for hiding this comment

zhwesky2010 commented Aug 28, 2023

enkilee commented Aug 28, 2023

enkilee commented Aug 30, 2023 • edited Loading

zhwesky2010 commented Sep 4, 2023 • edited Loading

enkilee commented Sep 5, 2023

enkilee commented Sep 5, 2023 • edited Loading

zhwesky2010 Sep 7, 2023 • edited Loading

Choose a reason for hiding this comment

enkilee Oct 20, 2023

Choose a reason for hiding this comment

zhwesky2010 Nov 1, 2023

Choose a reason for hiding this comment

zhwesky2010 Nov 1, 2023

Choose a reason for hiding this comment

enkilee commented Jul 14, 2023 •

edited

Loading

enkilee commented Jul 17, 2023 •

edited

Loading

zhwesky2010 left a comment •

edited

Loading

zhwesky2010 Aug 18, 2023 •

edited

Loading

enkilee commented Aug 30, 2023 •

edited

Loading

zhwesky2010 commented Sep 4, 2023 •

edited

Loading

enkilee commented Sep 5, 2023 •

edited

Loading

zhwesky2010 Sep 7, 2023 •

edited

Loading