-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
单测case增强4 #458
单测case增强4 #458
Conversation
Thanks for your contribution! |
@@ -12605,7 +12608,7 @@ | |||
"min_input_args": 2 | |||
}, | |||
"torch.nn.functional.softmax": { | |||
"Matcher": "RequireDimMatcher", | |||
"Matcher": "SoftmaxMatcher", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RequireDimMatcher是不是没用了可以删掉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个我在之后的PR再删除吧,因为这个Matcher还涉及到其余几个单测,改动的话需要改其余几个算子的单测,要是都在这里改的话可能提交的文件有些过多了
[[1.0, 2.0, 3.0, 4.0], | ||
[5.0, 6.0, 7.0, 8.0], | ||
[6.0, 7.0, 8.0, 9.0]]]) | ||
model = nn.LogSoftmax(dim=None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没有dim的情况测一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testcase3就是没有dim的情况 以及这个PR修改的这个文件主要是为了防止CI报错,其实在单测case增强3这个PR中对这两个文件修改是同样的
[[1.0, 2.0, 3.0, 4.0], | ||
[5.0, 6.0, 7.0, 8.0], | ||
[6.0, 7.0, 8.0, 9.0]]]) | ||
model = nn.Softmax(dim=None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没有dim的情况测一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testcase3就是没有dim的情况
["result"], | ||
check_value=False, | ||
unsupport=True, | ||
reason="paddle unsupport layer_norm_eps args", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
batch_first测一个
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个在testcase7中有,并且paddle貌似目前也不支持这个参数
@@ -148,3 +148,54 @@ def test_case_7(): | |||
unsupport=True, | |||
reason="paddle unsupport batch_first args", | |||
) | |||
|
|||
|
|||
def test_case_8(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
新加的bias参数有实质性测试到了的吗
@@ -78,3 +78,44 @@ def test_case_4(): | |||
unsupport=True, | |||
reason="paddle unsupport batch_first args", | |||
) | |||
|
|||
|
|||
def test_case_5(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
新加的bias参数有实质性测试到了的吗
@@ -123,3 +123,45 @@ def test_case_7(): | |||
""" | |||
) | |||
obj.run(pytorch_code, ["result"], check_value=False) | |||
|
|||
|
|||
def test_case_8(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
新加的bias参数有实质性测试到了的吗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Docs
单测case增强4
PR APIs