Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix swish op bug in conv_activation_fuser, conv_scale_fuser and scale_activation_fuser. #10516

Merged
merged 1 commit into from
May 17, 2024

Conversation

ddchenhao66
Copy link
Collaborator

PR devices

Framework

PR types

Bug fixes

PR changes

PASS

Description

fix fusers related with swish op

Copy link

paddle-bot bot commented May 13, 2024

Thanks for your contribution!

@@ -13,6 +13,7 @@
// limitations under the License.

#include "lite/core/optimizer/mir/fusion/conv_activation_fuser.h"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么需要加多余的空行?

@@ -13,6 +13,7 @@
// limitations under the License.

#include "lite/core/optimizer/mir/fusion/conv_scale_fuser.h"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

@@ -13,6 +13,7 @@
// limitations under the License.

#include "lite/core/optimizer/mir/fusion/conv_activation_fuser.h"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR 的 标题再改下吧,可以用百度、谷歌、一言翻译协助一下,否则都没办法快速了解 PR 的修改点。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修改为[core] fix swish op bug in conv_activation_fuser、conv_scale_fuser and scale_activation_fuser.

@ddchenhao66 ddchenhao66 changed the title [core] fix fusers related with swish op,test=develop [core] fix swish op bug in conv_activation_fuser, conv_scale_fuser and scale_activation_fuser. May 17, 2024
Copy link
Collaborator

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ddchenhao66 ddchenhao66 merged commit 0741366 into PaddlePaddle:develop May 17, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants