Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile Paddle on Windows System #290

Closed
gangliao opened this issue Oct 30, 2016 · 8 comments
Closed

Compile Paddle on Windows System #290

gangliao opened this issue Oct 30, 2016 · 8 comments
Assignees

Comments

@gangliao
Copy link
Contributor

gangliao commented Oct 30, 2016

Related Project

@wangkuiyi
Copy link
Collaborator

@gangliao 请说明

  1. 为什么会有这个需求,
  2. 为了解决它需要做什么

给定这些信息,我们才有依据如何处理,比如放进哪个milestone里。

@gangliao
Copy link
Contributor Author

@wangkuiyi
Request came from #5.
To port Paddle on Windows:

  1. revise CMake to support Windows(MSVC).
  2. add Win32 socket APIs for networks.
  3. add Windows-related APIs for system-level stuff.
  4. unite dynamic load libraries interfaces for all operating systems.
  5. fix bugs and unit test on Windows.

@reyoung reyoung self-assigned this Oct 31, 2016
@gangliao
Copy link
Contributor Author

Predicting how long to end this long-term work is difficult, so it's not added into any of recent milestones.

@reyoung
Copy link
Collaborator

reyoung commented Oct 31, 2016

@gangliao I will review them tomorrow, when I'm on duty for github issues.

Duty day is a good chance to review PR. :-)

@wangkuiyi This feature is not associated to any milestone because we just finish to compile on Windows, but there is no continuous integration and regression test for it. Also the install package for windows should be added.

So, we should do discuss it layer when ci, install pack, etc is done.

I will add a project to track it.

@reyoung reyoung changed the title Porting Paddle on Windows Compile Paddle on Windows System Oct 31, 2016
@reyoung
Copy link
Collaborator

reyoung commented Oct 31, 2016

@gangliao Sorry, i just notice that this is an issue, not a PR.

Is windows compile ready to send a PR now?

@gangliao
Copy link
Contributor Author

@reyoung maybe a little bit later..

@wangkuiyi
Copy link
Collaborator

wangkuiyi commented Oct 31, 2016

@reyoung @gangliao I would suggest we deny this requirement and close this issue as well as #5. Given that Microsoft Azure is running Linux, I don't see a Windows port would make Paddle much popular. To serve the community well, we need to prioritize.

@wangkuiyi
Copy link
Collaborator

I had a discussion about this issue with @emailweixu today. Given that Mac and Window can both run Docker using native virtualization mechanism, in particular,

  1. Windows: https://docs.docker.com/engine/installation/windows/
  2. Mac: https://docs.docker.com/engine/installation/mac/

I believe that we should encourage users to run Paddle in Docker containers on Mac and Windows.

If we see enough number of +1's accumulate in #5 in the future, we can move on working on Windows (or Mac) ports. For now, let us let focus on making Paddle runs well with Linux.

gglin001 pushed a commit to graphcore/Paddle-fork that referenced this issue Dec 8, 2021
wangxicoding pushed a commit to wangxicoding/Paddle that referenced this issue Dec 9, 2021
zmxdream pushed a commit to zmxdream/Paddle that referenced this issue May 17, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this issue Sep 13, 2023
lizexu123 pushed a commit to lizexu123/Paddle that referenced this issue Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants