Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add boost to inference lib #10660

Merged
merged 4 commits into from
May 16, 2018

Conversation

jacquesqiao
Copy link
Member

@jacquesqiao jacquesqiao commented May 15, 2018

tasks: #10574

Our executor depends on boost, if a C++ module use fluid executor but cannot find the boost, the build will fail.
image

After add boost to the include_directories, it can build success.

image

@jacquesqiao jacquesqiao requested a review from luotao1 May 15, 2018 08:15
set(dst_dir "${CMAKE_INSTALL_PREFIX}/third_party/install/boost")
copy(boost_lib
SRCS ${BOOST_INCLUDE_DIR}
DSTS ${dst_dir}
Copy link
Contributor

@luotao1 luotao1 May 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里需要调整下,目前打包:

boost/
└── boost_1_41_0
    ├── boost
    ├── boost-build.jam
    ├── boost.css
    ├── boost.png
    ├── bootstrap.bat
    ├── bootstrap.sh
    ├── CMakeLists.txt
    ├── doc
    ├── index.htm
    ├── index.html
    ├── INSTALL
    ├── Jamroot
    ├── libs
    ├── LICENSE_1_0.txt
    ├── more
    ├── people
    ├── README.txt
    ├── rst.css
    ├── status
    ├── tools
    └── wiki
  1. boost/boost_1_41_0/boost里面才是需要使用的头文件
  2. boost头文件一共63M,但目前打包的内容有273M:原因是打包了doc/tools等其他目录。
[luotao02@yq01-idl-gpu-jpaas-let01: boost_1_41_0] -> $ du -sh *
63M	boost
4.0K	boost-build.jam
4.0K	boost.css
8.0K	boost.png
4.0K	bootstrap.bat
12K	bootstrap.sh
4.0K	CMakeLists.txt
52M	doc
4.0K	index.htm
8.0K	index.html
4.0K	INSTALL
24K	Jamroot
143M	libs
4.0K	LICENSE_1_0.txt
596K	more
8.0K	people
8.0K	README.txt
4.0K	rst.css
4.0M	status
13M	tools
8.0K	wiki
  1. boost库不应该装在install目录下,应该和eigen的位置一样。因为paddle编译的时候也没有装在install目录下,所以要保持统一。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jacquesqiao jacquesqiao requested a review from Xreki May 15, 2018 09:51
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Xreki
Copy link
Contributor

Xreki commented May 15, 2018

这个问题很奇怪,确实多个业务方都反馈过需要boost库,但是我没能复现出来。

@Xreki Xreki added the 预测 原名Inference,包含Capi预测问题等 label May 15, 2018
@jacquesqiao
Copy link
Member Author

@Xreki 应该是因为你本地编译环境里面有线程的boost库。

@Xreki
Copy link
Contributor

Xreki commented May 15, 2018

应该是因为你本地编译环境里面有线程的boost库。

我应该是卸载了jumbo下面的,系统路径应该没有安装过。我再确认一下。

@jacquesqiao
Copy link
Member Author

公司环境系统环境貌似是有一个默认的

@jacquesqiao jacquesqiao merged commit 6c32052 into PaddlePaddle:develop May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
预测 原名Inference,包含Capi预测问题等
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants