Modify word2vec example using new LoDTensor API #10888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidgoyal78
reviewed
May 24, 2018
There was a problem hiding this comment.
Thanks for the PR. Let's wait before we merge this, we just found out that this book chapter is not in the CMake file. Moreover it has some other errors, so @daming-lu is fixing those now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check #10735 for why we are doing this.
To solve the issue above, we have merged a PR #10817 and now there is utility functions here to create LoDTensor.
So this means that we can simplify the book example code using the new API.
This PR tries to simplify the new word2vec book example.