improve efficiency of dot op in dygraph mode #23856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanxianghit
reviewed
Apr 15, 2020
| @@ -440,6 +440,10 @@ def dot(x, y, name=None): | |||
|
|
|||
| """ | |||
| op_type = 'dot' | |||
| if in_dygraph_mode(): | |||
There was a problem hiding this comment.
由于目前ci排队时间比较长，可以先merge，后续补充注释
lanxianghit
previously approved these changes
Apr 15, 2020
phlrain
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type check consumes too much time in dygraph mode: about 8~10 times to other framework.
Change the code to call API directly in dygraph mode.