ENH: Refine Tensor and Add CopyFrom #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiayiFeng
reviewed
Jul 25, 2017
| class PODDeleter { | ||
| static_assert(std::is_pod<T>::value, "T must be POD"); |
There was a problem hiding this comment.
Why shall we use static_assert instead of template parameter? Any benefit?
There was a problem hiding this comment.
- SFINAE is a versatile and powerful but potentially complicated.
static_assertmakes more verbatim and hence clearer code.static_asserthas the benefit of a clearer compiler error message
There was a problem hiding this comment.
I agree that in this case, where we don't have other templates for PODDeleter, static_assert is the right choice.
gangliao
changed the title
wangkuiyi
approved these changes
Jul 27, 2017
| class PODDeleter { | ||
| static_assert(std::is_pod<T>::value, "T must be POD"); |
There was a problem hiding this comment.
I agree that in this case, where we don't have other templates for PODDeleter, static_assert is the right choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add both CPU and GPU CopyFrom Unit Test