Struct SparseValue && Bug Fix #31721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I516fe974422decaa29c8f1cc70d7ad71f110e732
Change-Id: I4824a4036e1ea5e6da05d66883afe428fe9a339d
Change-Id: I93eedd86d521cc26b05223c3f44c575063e366b3
Change-Id: Idcf48fc9356645d2034e78855dc1a18bb1202cbc
Change-Id: Iacfa0e417ba12293c23add5c17aab9fa00be994f
|
Thanks for your contribution! |
… fix/sparse_value Change-Id: I57f1d38ebb78d3c4363945f848d15b5f6cbe3b0c
a6802739
reviewed
Mar 24, 2021
| std::vector<int>* offset_shard) const { | ||
| offset_shard->reserve(numel_ / shard_num + 1); | ||
| for (int x = 0; x < numel_; ++x) { | ||
| if (x % shard_num == shard_id) { |
There was a problem hiding this comment.
这样写会有问题，应该是 feasigns_[x] % shard_num == shard_id
Change-Id: Iac18e5dcc6fb363f844b79581f9d09077f2d9288
Change-Id: Ie858cdec6dae2bbe9e907ca3a57d286b704eb450
Change-Id: Ie35a09772e46f7d90cb68ca82c1d18b9201d1abe
| // Pull sparse variables from server in sync mode | ||
| // pull immediately to tensors | ||
| void PullSparseToTensorSync(const uint64_t table_id, int fea_dim, | ||
| uint64_t padding_id, platform::Place place, | ||
| bool is_training, |
There was a problem hiding this comment.
add comments please.
Change-Id: I8a06a74f1f482058e2b7479a9a7bd03c6272076e
Change-Id: Icab139e966696b122d331707682351539905dd16
raindrops2sea
approved these changes
Apr 7, 2021
luotao1
approved these changes
Apr 7, 2021
chalsliu
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
1.修复在分布式预测时，在使用准入策略是，由于未针对预测场景做针对性过滤触发准入条件导致计数及初始化错误.
2.修复在分布式训练时，由于远端拉取稀疏特征时的去重导致Server端对特征的频率计数错误.
Base speed:
{'speed': [83504, 81608, 81701, 83903, 86251]}
PR speed:
'speed': [82247, 85332, 85383, 83559, 86213]
Base AUC:
{'0': 0.7053, '1': 0.7394, '2': 0.7534, '3': 0.7623, '4': 0.7693}}
PR AUC:
{'0': 0.7112, '1': 0.7401, '2': 0.7561, '3': 0.7639, '4': 0.7701}