Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCM] fix softmax_with_cross_entropy_op #31982

Merged
merged 1 commit into from
Apr 2, 2021
Merged

[ROCM] fix softmax_with_cross_entropy_op #31982

merged 1 commit into from
Apr 2, 2021

Conversation

ronny1996
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Describe

fix softmax_with_cross_entropy_op

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

qili93
qili93 approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Apr 1, 2021
@PaddlePaddle PaddlePaddle unlocked this conversation Apr 1, 2021
@qili93 qili93 requested a review from Xreki April 1, 2021 13:17
Xreki
Xreki approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op benchmark ci

@qili93 qili93 merged commit 9e06a64 into PaddlePaddle:develop Apr 2, 2021
ronny1996 added a commit to ronny1996/Paddle that referenced this pull request Apr 2, 2021
@ronny1996
[ROCM] fix softmax_with_cross_entropy_op (PaddlePaddle#31982)
e12798d
qili93 pushed a commit that referenced this pull request Apr 2, 2021
@ronny1996
[ROCM] fix softmax_with_cross_entropy_op (#31982) (#32050)
ed50530
@ronny1996 ronny1996 deleted the rocm-dev branch April 6, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qili93 qili93 qili93 approved these changes

@Xreki Xreki Xreki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronny1996 @Xreki @qili93