Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added slice BF16/FP32 FWD/BWD kernels #34332

Merged
merged 14 commits into from
Sep 1, 2021
Merged

Added slice BF16/FP32 FWD/BWD kernels #34332

merged 14 commits into from
Sep 1, 2021

Conversation

jakpiase
Copy link
Contributor

PR types

New features

PR changes

OPs

Describe

Added slice BF16/FP32 FWD/BWD kernels.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@lidanqing-intel lidanqing-intel added this to the v2.2 milestone Aug 20, 2021
@lidanqing-intel
Copy link
Contributor

lidanqing-intel commented Aug 30, 2021 •
edited
Loading

@sfraczek Hi, if you have time, Could you please help review? Thanks !

lidanqing-intel
lidanqing-intel previously approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@lidanqing-intel lidanqing-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja jczaja requested a review from wozna August 30, 2021 08:09
wozna
wozna previously approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@wozna wozna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments that are only related to factoring, so feel free to add that later. The rest LGTM.

paddle/fluid/operators/slice_op.cc Outdated Show resolved Hide resolved
paddle/fluid/operators/slice_op.cc Outdated Show resolved Hide resolved
python/paddle/fluid/tests/unittests/mkldnn/test_slice_mkldnn_op.py Outdated Show resolved Hide resolved
python/paddle/fluid/tests/unittests/test_static_save_load_bf16.py Outdated Show resolved Hide resolved
@jakpiase jakpiase dismissed stale reviews from wozna and lidanqing-intel via 40b508b August 30, 2021 13:21
wozna
wozna approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@wozna wozna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lidanqing-intel
lidanqing-intel approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@lidanqing-intel lidanqing-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jczaja jczaja merged commit 070cab1 into PaddlePaddle:develop Sep 1, 2021
@baoachun baoachun mentioned this pull request Sep 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidanqing-intel lidanqing-intel lidanqing-intel approved these changes

@wozna wozna wozna approved these changes

@jczaja jczaja Awaiting requested review from jczaja

Assignees
No one assigned
Labels
BF16 Intel
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.
4 participants
@jakpiase @lidanqing-intel @wozna @jczaja