Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hybrid] [npu] fit npu nan/inf check #35171

Merged
merged 2 commits into from
Sep 2, 2021

Conversation

FeixLiu
Copy link
Contributor

@FeixLiu FeixLiu commented Aug 26, 2021

PR types

Bug fixes

PR changes

Others

Describe

Fix the fused var for npu

详细问题可参考:#35144
PR #35165 解决了问题1
PR #35134 解决了问题2
本PR解决一半的问题3,针对npu,对于每一个micro step的fused grad var进行初始化.
问题3的另一半问题是,昇腾算子会使用改写自己维度之后的值,可能使padding部分的值出现nan/inf。

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 26, 2021

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@wangxicoding wangxicoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeixLiu FeixLiu closed this Aug 31, 2021
@FeixLiu FeixLiu deleted the fix_npu_precision branch August 31, 2021 05:23
@FeixLiu FeixLiu restored the fix_npu_precision branch September 2, 2021 07:36
@FeixLiu FeixLiu reopened this Sep 2, 2021
@wangxicoding wangxicoding changed the title [hybrid] fit npu nan/inf check [hybrid] [npu] fit npu nan/inf check Sep 2, 2021
@wangxicoding wangxicoding merged commit 67ed7e1 into PaddlePaddle:develop Sep 2, 2021
@FeixLiu FeixLiu deleted the fix_npu_precision branch September 2, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants