Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second fix to #34554 #36290

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Second fix to #34554 #36290

merged 1 commit into from
Oct 13, 2021

Conversation

jczaja
Copy link
Contributor

@jczaja jczaja commented Oct 8, 2021

PR types

Bug fixes

PR changes

Others

Describe

Clearing of caching mechanism

@paddle-bot-old
Copy link

paddle-bot-old bot commented Oct 8, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jczaja jczaja added the Intel label Oct 8, 2021
@jczaja
Implemented LRU based cache clearing
006f33f 
- Lint

- Merge with develop

- lint
jakpiase
jakpiase approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@jakpiase jakpiase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lidanqing-intel
lidanqing-intel approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@lidanqing-intel lidanqing-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidanqing-intel
Copy link
Contributor

lidanqing-intel commented Oct 13, 2021 •
edited
Loading

@OliverLPH Hi, this is last fix, Could you please verify on Baidu 6271? And does these fix PRs need to be cherry-picked to release/2.2 ?

@OliverLPH
Copy link
Contributor

@lidanqing-intel could you please merge it into develop first.
later this week I will verify the latest develop Paddle. If it works fine, then cherry-pick to release/2.2 ?

@lidanqing-intel lidanqing-intel merged commit bf748f2 into PaddlePaddle:develop Oct 13, 2021
@jczaja
Copy link
Contributor Author

jczaja commented Oct 13, 2021

@OliverLPH I discovered some problems (crashes) in issue #34554 with this PR merged. So it is not yet solved. I'm still investigating. If you have any observations please write them in #34554 as it was helpful for me some easier reproductions you have described.

lidanqing-intel added a commit to lidanqing-intel/Paddle that referenced this pull request Oct 14, 2021
@lidanqing-intel
Revert "Implemented LRU based cache clearing (PaddlePaddle#36290)"
3c2fdc6 
This reverts commit bf748f2.
@lidanqing-intel lidanqing-intel mentioned this pull request Oct 14, 2021
Merged
@qili93
Copy link
Contributor

qili93 commented Oct 14, 2021

Hi @lidanqing-intel,

This PR broken Paddle compile on ARM due to missing header file of "x86intrin.h" in aarch64 environment.

Please kindly help to revert this PR and fix, thanks!

f6397938193206bc73c70b7df9cc1257

lidanqing-intel added a commit that referenced this pull request Oct 14, 2021
@lidanqing-intel
Revert "Implemented LRU based cache clearing (#36290)" (#36426)
5d18967 
This reverts commit bf748f2.
@lidanqing-intel
Copy link
Contributor

lidanqing-intel commented Oct 14, 2021 •
edited
Loading

@qili93 Hi, revert PR Revert #36426 is merged just now, could you please verify latest develop again if compiling on ARM works? Sorry for inconvenience. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakpiase jakpiase jakpiase approved these changes

@lidanqing-intel lidanqing-intel lidanqing-intel approved these changes

Assignees
No one assigned
Labels
Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jczaja @lidanqing-intel @OliverLPH @qili93 @jakpiase