Support various length support for SelectedRows in GLOO::AllGather #36637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
XieYunshen
reviewed
Oct 25, 2021
Aurelius84
approved these changes
Oct 26, 2021
Aurelius84
changed the title
2742195759
added a commit
to 2742195759/Paddle
that referenced
this pull request
Oct 26, 2021
…addlePaddle#36637) * In cpu parallel using gloo, add various length support for SelectedRows * fix bug * fix bugs * fix by code review * remove timeout
lanxianghit
pushed a commit
that referenced
this pull request
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
In cpu parallel using gloo, add various length support for SelectedRows.
之前受限于GlooWrapper，无法实现变长的sparse tensor的all reduce同步。gloo会报错不支持。
现在添加了对应的支持，不会报错了。这个性质在NLP中非常重要。
功能补齐PR。