[fleet_executor] handle empty addr for single card train #37150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
wangxicoding
approved these changes
Nov 12, 2021
| @@ -125,6 +129,10 @@ bool MessageBus::IsSameRank(int64_t src_id, int64_t dst_id) { | |||
| dst_rank, interceptor_id_to_rank_.end(), | |||
| platform::errors::NotFound( | |||
| "Cannot find rank for dst interceptor id %lld. Init error.", dst_id)); | |||
| if (addr_ == "") { | |||
There was a problem hiding this comment.
可以优化一下，应该不需要判断addr是否相同，直接判断src_rank == dst_rank就行
There was a problem hiding this comment.
TODO:
1.Remove the src_id's ip check, or mote to other place.
2.Remove this check since it does the same thing with line 147.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
handle empty addr for single card train