Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize flip op, removing duplicated computation when dim size is one #37825

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

sljlp
Copy link
Contributor

@sljlp sljlp commented Dec 3, 2021

PR types

Performance optimization

PR changes

OPs

Describe

当dim size是1 的时候,paddle.flip性能比竞品性能低一倍,原因是当dim size 是1的时候,多执行一步pointwise kernel
现将这一步删掉,性能就可跟竞品打平。dim size > 1,性能正常
tensor shape 10000 x 10000
循环1000步,耗时对比:
image

@paddle-bot-old
Copy link

paddle-bot-old bot commented Dec 3, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@wangxicoding wangxicoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangxicoding wangxicoding merged commit 890638c into PaddlePaddle:develop Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants