block warning when building cryptopp in windows with ninja #37890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhwesky2010
reviewed
Dec 7, 2021
| @@ -447,7 +447,7 @@ if (MSVC) | |||
| if (CMAKE_SYSTEM_VERSION MATCHES "10\\.0.*") | |||
| list(APPEND CRYPTOPP_COMPILE_DEFINITIONS "_WIN32_WINNT=0x0A00") | |||
| endif () | |||
| list(APPEND CRYPTOPP_COMPILE_OPTIONS "/FIwinapifamily.h") | |||
| list(APPEND CRYPTOPP_COMPILE_OPTIONS "/nologo") | |||
There was a problem hiding this comment.
FIwinapifamily.h起什么作用，nologo起什么作用，有没可能去除patches。patches一般都是冗余代码，如果没有必须的作用，尽可能去除
There was a problem hiding this comment.
- /FI：添加预处理的包含文件。
- winapifamily.h 是在开发不同平台（win32桌面应用、手机商店应用、游戏和app等）的app时用来指定Windows api家族用的，当指定为某平台时，在编译时将隐藏其他平台的APIS。
- /nologo：去除版权显示
- 若去除patches，则需要改动cryptopp的源文件CMakeLists.txt, 以删除"/FIwinapifamily.h"选项，相比pathes在版权方面没那么好。
zhwesky2010
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Both "/FI"winapifamily.h"" and "/FIwinapifamily.h" will cause compile warning when building cryptopp in windows with ninja, so I substitute it by "/nologo" to block showing of copyright by the way.
before
after