Support FP16 mean #38289
Merged
Support FP16 mean #38289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
| private: | ||
| T n_inv; | ||
| }; | ||
|
|
||
| template <typename T> | ||
| __global__ void MeanRunKernel(const T* in_data, T* out_data, int N) { |
There was a problem hiding this comment.
目前mean 和reducemean调用的都是pten里面的reduce，由chen tian yu进行修改。可以确认一下修改是否起作用了
There was a problem hiding this comment.
已打log确认，确实能调到，因为PTen没有FP16的注册。后续PR会在PTen里添加注册。
| @@ -77,7 +77,7 @@ struct CustomSub { | |||
|
|
|||
| template <typename Tx, typename Ty = Tx> | |||
| struct CustomMean { | |||
| using Transformer = kps::DivideFunctor<Tx>; | |||
| using Transformer = kps::DivideFunctor<Tx, Ty>; | |||
There was a problem hiding this comment.
在最新的reduce_op.cu.h中是没用到CustomMean的，本来计划删除，但是pten用到了，你只修改这里是不会对pten中reduce实现有修改的，不过他们好像在移动代码
There was a problem hiding this comment.
已打log确认，确实能调到，因为PTen没有FP16的注册。后续PR会在PTen里添加注册。
| @@ -19,5 +19,7 @@ | |||
| REGISTER_OP_CUDA_KERNEL( | |||
| reduce_mean, | |||
| ops::ReduceCudaKernel<bool, kps::AddFunctor, kps::DivideFunctor>, | |||
| ops::ReduceCudaKernel<paddle::platform::float16, kps::AddFunctor, | |||
| kps::DivideFunctor>, | |||
There was a problem hiding this comment.
chentianyu说对于mean和sum pten内部是添加了注册的，请确认修改这里是否真正能够调用fp16
There was a problem hiding this comment.
已打log确认，确实能调到，因为PTen没有FP16的注册。后续PR会在PTen里添加注册。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
Support FP16 for
meanandreduce_meanops.