-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update passes in quant2_int8_mkldnn_pass #38912
Conversation
Thanks for your contribution! |
@wozna @pmajchrzak Please verify this PR will not cause our existing daily CI int8 models accuracy and performance drop. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wozna Hi could you or ask Pior to upload spreadsheet showing this PR does not cause any accuracy drop or performance drop on exisiting int8 modes CI |
I can confirm that all recent changes don't cause any accuracy change or performance change in any model from our CI. Before I had a problem with |
@lidanqing-intel @sfraczek Could you please repeat your review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@baoachun Could you please review this PR. Thanks |
@baoachun Hi could you please approve this PR? Some models from BML team still need to use save_quant_model.py solution for now. So we still need to maintain this save_quant_model.py. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Bug fixes
PR changes
Others
Describe
This PR updates passes that are applied to the graph during quant2_int8_mkldnn_pass. It turns out that many passes were added to CpuPassStrategy and EnableMkldnn passes, but they weren't added to mentioned python script. I used the same order of the passes that is presented in
paddle_pass_builder.cc
.