Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Eager Hook] Support eager hook_for_layer #39531

Merged
merged 5 commits into from
Feb 16, 2022
Merged

[Eager Hook] Support eager hook_for_layer #39531

merged 5 commits into from
Feb 16, 2022

Conversation

veyron95
Copy link
Contributor

@veyron95 veyron95 commented Feb 14, 2022 •
edited
Loading

PR types

New features

PR changes

Others

Describe

  1. Support test_imperative_hook_for_layer with _test_eager_guard()
  2. Polish the code, use "forward_post_hook" instead of "forward_hook",this will be more standardized.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

JiabinYang
JiabinYang reviewed Feb 15, 2022
View reviewed changes
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid copy

JiabinYang
JiabinYang approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ, LGTM

@veyron95 veyron95 merged commit a909bdf into PaddlePaddle:develop Feb 16, 2022
@veyron95 veyron95 changed the title [Eager] Support eager hook_for_layer [Eager Hook] Support eager hook_for_layer Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dingjiaweiww dingjiaweiww dingjiaweiww approved these changes

@JiabinYang JiabinYang JiabinYang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veyron95 @JiabinYang @dingjiaweiww