[Phi]Move bincount OP to phi #39947
Merged
[Phi]Move bincount OP to phi #39947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zyfncg
reviewed
Feb 28, 2022
|
|
||
| if (has_weights) { | ||
| const T* weights_data = weights->data<T>(); | ||
| if (weights->dtype() == DataType::INT32) { |
There was a problem hiding this comment.
是的应该判断FLOAT32，已经修改，感谢
YuanRisheng
previously approved these changes
Feb 28, 2022
似乎是没有，要先添加脚本再合入代码是吗 |
按现在的规范得先加一下benchmark脚本了 |
YuanRisheng
approved these changes
Mar 7, 2022
zyfncg
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
[Phi]Move bincount OP to phi
已添加benchmark脚本: PaddlePaddle/benchmark#1328