Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hybrid] fused_feedforward op support tensor model parallel #40160

Merged
merged 2 commits into from
Mar 9, 2022
Merged

[hybrid] fused_feedforward op support tensor model parallel #40160

merged 2 commits into from
Mar 9, 2022

Conversation

wangxicoding
Copy link
Contributor

@wangxicoding wangxicoding commented Mar 4, 2022 •
edited
Loading

PR types

New features

PR changes

OPs

Describe

fused_feedforward op support tensor model parallel.
First column parallel linear, then row parallel linear, then we will got partial out, we can use allreduce to get final output.
image

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 4, 2022

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@wangxicoding wangxicoding changed the title fused_feedforward op support tensor model parallel [hybrid] fused_feedforward op support tensor model parallel Mar 8, 2022
XieYunshen
XieYunshen approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for set_tests_properties(test_static_model_parallel_fused_feedforward PROPERTIES TIMEOUT 120)

FeixLiu
FeixLiu approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@FeixLiu FeixLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zkh2016
zkh2016 approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@zkh2016 zkh2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Superjomn
Superjomn approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangxicoding wangxicoding merged commit e0866dc into PaddlePaddle:develop Mar 9, 2022
@wangxicoding wangxicoding deleted the fused_ffn_support_mp branch March 9, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XieYunshen XieYunshen XieYunshen approved these changes

@FeixLiu FeixLiu FeixLiu approved these changes

@zkh2016 zkh2016 zkh2016 approved these changes

@Superjomn Superjomn Superjomn approved these changes

@qingqing01 qingqing01 Awaiting requested review from qingqing01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wangxicoding @Superjomn @zkh2016 @FeixLiu @XieYunshen