Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Phi] Migrate Adam and AdamW into Phi #40351

Merged
merged 23 commits into from
Mar 25, 2022

Conversation

Aurelius84
Copy link
Contributor

@Aurelius84 Aurelius84 commented Mar 9, 2022

PR types

Function optimization

PR changes

OPs

Describe

[Phi] Migrate Adam and AdamW into Phi

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 9, 2022

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

paddle/phi/kernels/adam_kernel.h Outdated Show resolved Hide resolved
paddle/phi/kernels/adamw_kernel.h Outdated Show resolved Hide resolved
paddle/phi/kernels/cpu/adam_kernel.cc Outdated Show resolved Hide resolved
paddle/phi/kernels/cpu/adamw_kernel.cc Show resolved Hide resolved
paddle/phi/kernels/gpu/adam_kernel.cu Outdated Show resolved Hide resolved
zyfncg
zyfncg previously approved these changes Mar 15, 2022
paddle/phi/infermeta/multiary.cc Outdated Show resolved Hide resolved
paddle/phi/kernels/adam_kernel.h Outdated Show resolved Hide resolved
paddle/phi/kernels/adamw_kernel.h Outdated Show resolved Hide resolved
YuanRisheng
YuanRisheng previously approved these changes Mar 15, 2022
Copy link
Contributor

@MingMingShangTian MingMingShangTian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlrain phlrain self-requested a review March 25, 2022 02:54
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 merged commit 56cd340 into PaddlePaddle:develop Mar 25, 2022
Aurelius84 added a commit to Aurelius84/Paddle that referenced this pull request Apr 12, 2022
phlrain pushed a commit that referenced this pull request Apr 13, 2022
* Revert "[Phi] Migrate Adam and AdamW into Phi (#40351)"

This reverts commit 56cd340.

* add infermeta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants