-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Phi] Migrate Adam and AdamW into Phi #40351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution! |
Aurelius84
requested review from
chenwhql,
YuanRisheng,
zyfncg and
MingMingShangTian
March 9, 2022 07:15
YuanRisheng
reviewed
Mar 11, 2022
zyfncg
reviewed
Mar 11, 2022
zyfncg
previously approved these changes
Mar 15, 2022
YuanRisheng
previously approved these changes
Mar 15, 2022
MingMingShangTian
previously approved these changes
Mar 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Aurelius84
dismissed stale reviews from MingMingShangTian, YuanRisheng, and zyfncg
via
March 15, 2022 08:18
c657b59
zyfncg
approved these changes
Mar 25, 2022
YuanRisheng
approved these changes
Mar 25, 2022
chenwhql
approved these changes
Mar 25, 2022
phlrain
approved these changes
Mar 25, 2022
XiaoguangHu01
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Aurelius84
added a commit
to Aurelius84/Paddle
that referenced
this pull request
Apr 12, 2022
This reverts commit 56cd340.
phlrain
pushed a commit
that referenced
this pull request
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
[Phi] Migrate Adam and AdamW into Phi