Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Phi] Move part sum op kernel #40873

Merged
merged 3 commits into from
Mar 25, 2022

Conversation

chenwhql
Copy link
Contributor

@chenwhql chenwhql commented Mar 23, 2022

PR types

Function optimization

PR changes

OPs

Describe

[Phi] Move part sum op kernel

这个sum op参数组合情况极为复杂,现阶段仅迁移支持DenseTensor的版本,以支持动态图yaml接入:

  • 输入:vector<Variable>, Variable为DenseTensor,SelectedRows,LoDTensorArray及其互相组合的成员,无法表示为vector<具体Tensor>
  • 输出:Variable,类型为DenseTensor,SelectedRows,LoDTensorArray

输入输出在逻辑上叉乘组合,Kernel数量也会很多

后续再尝试迁移其他情况,需要一些机制上的拓展才能完成

paddle/phi/ops/compat/sum_sig.cc Show resolved Hide resolved
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenwhql chenwhql merged commit 4ab8255 into PaddlePaddle:develop Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants