Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add multiclass nms3 trt converter #41181

Merged
merged 4 commits into from
Mar 31, 2022
Merged

add multiclass nms3 trt converter #41181

merged 4 commits into from
Mar 31, 2022

Conversation

wangxinxin08
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

add multiclass nms3 trt converter

XieYunshen
XieYunshen approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for set_tests_properties(test_trt_multiclass_nms3_op PROPERTIES TIMEOUT 60)

Wangzheee
Wangzheee approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@Wangzheee Wangzheee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码覆盖率不够，加的单测，没跑吗？

@heavengate heavengate merged commit 08c3edb into PaddlePaddle:develop Mar 31, 2022
@wangxinxin08
Copy link
Contributor Author

代码覆盖率不够，加的单测，没跑吗？

加的单测跑了，CI没有统计到，等会补充下CI能够统计到的单测

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XieYunshen XieYunshen XieYunshen approved these changes

@Wangzheee Wangzheee Wangzheee approved these changes

@heavengate heavengate heavengate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangxinxin08 @heavengate @Wangzheee @XieYunshen