Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick 2.3] Back port of "Fix to #38693 (minimal UT) " #42055

Merged
merged 1 commit into from
Apr 22, 2022
Merged

[cherry-pick 2.3] Back port of "Fix to #38693 (minimal UT) " #42055

merged 1 commit into from
Apr 22, 2022

Conversation

jczaja
Copy link
Contributor

@jczaja jczaja commented Apr 20, 2022

PR types

Bug fixes

PR changes

Others

Describe

Back port of fix to #38693 .

@jczaja
Add UT
2cfb5a5 
- Added missed data_layout

- Added missing conversions

- NDHWC added

- NDHWC support in data_transform

- another fix

- condddate change

- fix

u- fix

- fix

- fix

- fix

- fix

- fix to hack

- compilation fix

- fix to automatic merge

- reduced UT

- fix

- lint

- fix to lint
@jczaja jczaja added the Intel label Apr 20, 2022
@paddle-bot-old paddle-bot-old bot added contributor External developers status: proposed labels Apr 20, 2022
@paddle-bot-old
Copy link

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@lidanqing-intel lidanqing-intel changed the title Back port of "Fix to #38693 (minimal UT) " [cherry-pick 2.3] Back port of "Fix to #38693 (minimal UT) " Apr 20, 2022
lidanqing-intel
lidanqing-intel approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@lidanqing-intel lidanqing-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja
Copy link
Contributor Author

jczaja commented Apr 21, 2022

@XieYunshen Please approve setting timeout for test (this is backport of PR #41026 that you approved)

XieYunshen
XieYunshen approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for set_tests_properties(test_mkldnn_conv3d_op PROPERTIES TIMEOUT 300)

@lidanqing-intel
Copy link
Contributor

@baoachun Please help mering this bug fix cherry-pick PR. Thanks

Superjomn
Superjomn approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Superjomn Superjomn merged commit 4f6aba8 into PaddlePaddle:release/2.3 Apr 22, 2022
@paddle-bot-old paddle-bot-old bot removed the contributor External developers label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidanqing-intel lidanqing-intel lidanqing-intel approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

@Superjomn Superjomn Superjomn approved these changes

Assignees
No one assigned
Labels
Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jczaja @lidanqing-intel @Superjomn @XieYunshen