Feature/remove int pair #4374
Merged
Feature/remove int pair #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyoung
force-pushed
the
feature/remove_int_pair
branch
from
2e8d589
to
f4832fe
Compare
qingqing01
reviewed
Sep 26, 2017
| @@ -46,7 +40,6 @@ message OpDesc { | |||
| repeated int32 ints = 6; | |||
| repeated float floats = 7; | |||
| repeated string strings = 8; | |||
| repeated IntPair int_pairs = 9; | |||
| optional bool b = 10; | |||
There was a problem hiding this comment.
在重构阶段对proto改动不会影响兼容性，为啥不把后面的number也改了呢？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.