Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doc of clip op. #4422

Merged
merged 3 commits into from
Sep 27, 2017
Merged

Fix doc of clip op. #4422

merged 3 commits into from
Sep 27, 2017

Conversation

wanghaoshuang
Copy link
Contributor

fix #4421

@wanghaoshuang wanghaoshuang changed the title Fix InferShape of clip op. Fix doc of clip op. Sep 27, 2017
typhoonzero
typhoonzero reviewed Sep 27, 2017
View reviewed changes
paddle/operators/clip_op.cc Outdated
@@ -43,7 +45,7 @@ class ClipOpMaker : public framework::OpProtoAndCheckerMaker {
: OpProtoAndCheckerMaker(proto, op_checker) {
AddInput("X",
"(Tensor)The input of clip op."
"The input should be a k-D tensor(k > 0 and k < 7)");
"The dimension size of input tensor must be between [1, 9].");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dimension size => number of dimensions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx.

paddle/operators/clip_op.cc Outdated
@@ -17,6 +17,8 @@
namespace paddle {
namespace operators {

using framework::LoDTensor;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line seems not needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx.

typhoonzero
typhoonzero approved these changes Sep 27, 2017
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghaoshuang wanghaoshuang merged commit 3e96242 into PaddlePaddle:develop Sep 27, 2017
@wanghaoshuang wanghaoshuang deleted the fix_clip branch September 27, 2017 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typhoonzero typhoonzero typhoonzero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix doc of clip op.
2 participants
@wanghaoshuang @typhoonzero