Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OperatorBase::InferShape #4458

Merged

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Sep 28, 2017

InferShape in Operator should be performed in OperatorBase::Run.

  • cond_op, recurrent_op and mnist might be changed in following PR

InferShape in Operator should be performed in OperatorBase::Run.

* cond_op, recurrent_op and mnist might be changed in following PR
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reyoung reyoung merged commit 21f63ec into PaddlePaddle:develop Sep 28, 2017
@reyoung reyoung deleted the feature/compile_time_infer_shape branch October 2, 2017 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants