Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHI] Migrate softmax kernel #47339

Merged
merged 45 commits into from
Nov 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
00c2aca
add extra attr property set
chenwhql Sep 20, 2022
28e9710
add type_info for all context
chenwhql Sep 21, 2022
cd630f0
add onednn context to all context
chenwhql Sep 21, 2022
d633672
fix context compile error
chenwhql Sep 23, 2022
d651bf9
simplify conv kernel args
chenwhql Sep 23, 2022
84c56fa
pass runtime attr into dev_ctx
chenwhql Sep 26, 2022
24ea5b4
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
chenwhql Sep 26, 2022
fc67372
fix marco error
chenwhql Sep 26, 2022
ed7b59f
clear conv_grad_kernel extra args
chenwhql Sep 28, 2022
23cab07
merge conv_grad_grad into conv_grad
chenwhql Sep 28, 2022
123edd2
clear conv2d_grad_grad extra attrs
chenwhql Sep 28, 2022
d29a519
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
chenwhql Sep 28, 2022
b3aaf86
remove redundant imports
Silv3S Sep 29, 2022
3839f84
migrate softmax
Silv3S Sep 29, 2022
853b1db
clear yaml and eager extra attr
chenwhql Sep 30, 2022
62ce48b
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
chenwhql Sep 30, 2022
de52450
fix conv1d error
chenwhql Oct 10, 2022
2c55350
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
chenwhql Oct 10, 2022
03f6893
change to thread local
chenwhql Oct 11, 2022
49bcebe
fix npu compile failed
chenwhql Oct 11, 2022
ada7d0c
try to fix windows compile failed
chenwhql Oct 11, 2022
22ccfa9
add conv2d onednn phi kernel
chenwhql Oct 13, 2022
9602334
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
chenwhql Oct 14, 2022
6331512
fix ci bugs (#36)
YuanRisheng Oct 17, 2022
37afcf6
fix compile bugs (#38)
YuanRisheng Oct 17, 2022
39e2529
fix extra input transform bug (#39)
YuanRisheng Oct 18, 2022
16d595c
support dynamic created attr (#40)
YuanRisheng Oct 21, 2022
0d61412
resolve conflict with develop
chenwhql Oct 23, 2022
722b256
Merge branch 'adapto_extra_attr_in_phi' of https://github.com/chenwhq…
chenwhql Oct 23, 2022
8d59887
resolve conflict with develop
chenwhql Oct 24, 2022
c0cdb15
reset extra info gen code
chenwhql Oct 24, 2022
42bc76b
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
chenwhql Oct 24, 2022
dafdbcc
rm conv_grad_grad kernel
chenwhql Oct 24, 2022
e6d5312
reimpl pass attr adapting
chenwhql Oct 24, 2022
2b7c43d
resolve conflict with develop
chenwhql Oct 24, 2022
12e18f1
add int attr support
chenwhql Oct 24, 2022
2ea1a2b
remove vector inputnames creating
chenwhql Oct 25, 2022
d32b0be
Merge branch 'develop' into phi_migration_part_7
Silv3S Oct 25, 2022
b80ef68
merge dev
Silv3S Oct 25, 2022
148eebc
fix map at error
chenwhql Oct 25, 2022
2d42912
adjust attribute
Silv3S Oct 25, 2022
35b47af
Merge remote-tracking branch 'chen/adapto_extra_attr_in_phi' into sof…
Silv3S Oct 25, 2022
9111348
adapt funcs to PHI
Silv3S Oct 25, 2022
d92c4c7
Merge branch 'develop' into softmax_attributes
Silv3S Oct 27, 2022
7daea17
Merge branch 'develop' into softmax_attributes
Silv3S Nov 2, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#include "paddle/phi/core/kernel_registry.h"

USE_OP_ITSELF(softmax);
USE_OP_DEVICE_KERNEL(softmax, MKLDNN);
PD_DECLARE_KERNEL(softmax, OneDNN, ONEDNN);
USE_OP_ITSELF(elementwise_add);
USE_OP_DEVICE_KERNEL(elementwise_add, MKLDNN);
USE_OP_ITSELF(leaky_relu);
Expand Down
111 changes: 0 additions & 111 deletions paddle/fluid/operators/mkldnn/softmax_mkldnn_op.cc

This file was deleted.

2 changes: 1 addition & 1 deletion paddle/fluid/operators/mkldnn/test_mkldnn_caching.cc
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ USE_OP_DEVICE_KERNEL(elementwise_mul, MKLDNN);
USE_OP_ITSELF(relu);
PD_DECLARE_KERNEL(relu, OneDNN, ONEDNN);
USE_OP_ITSELF(softmax);
USE_OP_DEVICE_KERNEL(softmax, MKLDNN);
PD_DECLARE_KERNEL(softmax, OneDNN, ONEDNN);
USE_OP_ITSELF(conv2d);
PD_DECLARE_KERNEL(conv2d, OneDNN, ONEDNN);

Expand Down
3 changes: 1 addition & 2 deletions paddle/fluid/operators/mkldnn/test_mkldnn_op_inplace.cc
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ USE_OP_DEVICE_KERNEL(elementwise_add, MKLDNN);
USE_OP_ITSELF(relu);
PD_DECLARE_KERNEL(relu, OneDNN, ONEDNN);
USE_OP_ITSELF(softmax);
USE_OP_DEVICE_KERNEL(softmax, MKLDNN);

PD_DECLARE_KERNEL(softmax, OneDNN, ONEDNN);
PD_DECLARE_KERNEL(softmax, CPU, ALL_LAYOUT);

namespace paddle {
Expand Down
9 changes: 8 additions & 1 deletion paddle/phi/backends/onednn/onednn_reuse.h
Original file line number Diff line number Diff line change
Expand Up @@ -753,12 +753,19 @@ class SoftmaxOneDNNHandler
public:
SoftmaxOneDNNHandler(const dnnl::engine onednn_engine,
Place cpu_place,
int axis,
const DenseTensor* x,
int axis)
DenseTensor* out)
: OneDNNHandlerNoCachingT<T,
dnnl::softmax_forward,
dnnl::softmax_backward>(onednn_engine,
cpu_place) {
PADDLE_ENFORCE_EQ(
x->dims(),
out->dims(),
phi::errors::InvalidArgument(
"The shape of input and output tensor must be identical."));

const int canonical_axis = funcs::CanonicalAxis(axis, x->dims().size());
this->AcquireForwardPrimitiveDescriptor(
dnnl::prop_kind::forward_scoring, x->mem_desc(), canonical_axis);
Expand Down
61 changes: 61 additions & 0 deletions paddle/phi/kernels/onednn/softmax_kernel.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
// Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

#include "paddle/phi/kernels/softmax_kernel.h"

#include "paddle/phi/backends/onednn/onednn_reuse.h"
#include "paddle/phi/core/kernel_registry.h"

namespace phi {

template <typename T, typename Context>
void SoftmaxKernel(const Context& dev_ctx,
const DenseTensor& x,
int axis,
DenseTensor* out) {
funcs::SoftmaxOneDNNHandler<T> handler(
dev_ctx.GetEngine(), dev_ctx.GetPlace(), axis, &x, out);

auto src_memory_p = handler.AcquireSrcMemory(&x);
std::shared_ptr<dnnl::memory> dst_memory_p = nullptr;
if (x.IsSharedBufferWith(*out)) {
dst_memory_p = src_memory_p;
dev_ctx.template Alloc<T>(out);
} else {
dst_memory_p = handler.AcquireDstMemory(out);
}
auto softmax_p = handler.AcquireForwardPrimitive();

auto& astream = OneDNNContext::tls().get_stream();
softmax_p->execute(
astream, {{DNNL_ARG_SRC, *src_memory_p}, {DNNL_ARG_DST, *dst_memory_p}});
astream.wait();

bool is_test = dev_ctx.HasDnnAttr("is_test")
? PADDLE_GET_CONST(bool, dev_ctx.GetDnnAttr("is_test"))
: false;
if (!is_test) {
T* out_data = dev_ctx.template Alloc<T>(out);
std::for_each(out_data, &out_data[out->numel()], [](T& val) {
val = std::max(val, static_cast<T>(exp(-64)));
});
}

out->set_mem_desc(dst_memory_p->get_desc());
}

} // namespace phi

PD_REGISTER_KERNEL(
softmax, OneDNN, ONEDNN, phi::SoftmaxKernel, float, phi::dtype::bfloat16) {}